Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 653033002: Break deserializer reservations into chunks that fit onto a page. (Closed)

Created:
6 years, 2 months ago by Yang
Modified:
6 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Break deserializer reservations into chunks that fit onto a page. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24639

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -241 lines) Patch
M src/compiler.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/heap/heap.h View 1 1 chunk +10 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 3 chunks +28 lines, -22 lines 0 comments Download
M src/list.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/mksnapshot.cc View 1 3 chunks +25 lines, -7 lines 0 comments Download
M src/serialize.h View 1 14 chunks +89 lines, -47 lines 0 comments Download
M src/serialize.cc View 1 21 chunks +126 lines, -47 lines 0 comments Download
M src/snapshot-common.cc View 2 chunks +17 lines, -17 lines 0 comments Download
M src/snapshot-external.cc View 2 chunks +25 lines, -27 lines 0 comments Download
M src/vector.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 7 chunks +121 lines, -71 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 2 months ago (2014-10-14 11:02:15 UTC) #1
mvstanton
Couple of nits, but LGTM. https://codereview.chromium.org/653033002/diff/1/src/serialize.cc File src/serialize.cc (right): https://codereview.chromium.org/653033002/diff/1/src/serialize.cc#newcode1922 src/serialize.cc:1922: // Allocating a chunk ...
6 years, 2 months ago (2014-10-15 12:30:56 UTC) #2
Yang
6 years, 2 months ago (2014-10-15 14:05:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24639 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698