Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: src/snapshot-common.cc

Issue 653033002: Break deserializer reservations into chunks that fit onto a page. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments and rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/serialize.cc ('k') | src/snapshot-external.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The common functionality when building with or without snapshots. 5 // The common functionality when building with or without snapshots.
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/base/platform/platform.h" 10 #include "src/base/platform/platform.h"
11 #include "src/serialize.h" 11 #include "src/serialize.h"
12 #include "src/snapshot.h" 12 #include "src/snapshot.h"
13 13
14 namespace v8 { 14 namespace v8 {
15 namespace internal { 15 namespace internal {
16 16
17 void Snapshot::ReserveSpaceForLinkedInSnapshot(Deserializer* deserializer) { 17 void Snapshot::ReserveSpaceForLinkedInSnapshot(Deserializer* deserializer) {
18 deserializer->set_reservation(NEW_SPACE, new_space_used_); 18 deserializer->AddReservation(NEW_SPACE, new_space_used_);
19 deserializer->set_reservation(OLD_POINTER_SPACE, pointer_space_used_); 19 deserializer->AddReservation(OLD_POINTER_SPACE, pointer_space_used_);
20 deserializer->set_reservation(OLD_DATA_SPACE, data_space_used_); 20 deserializer->AddReservation(OLD_DATA_SPACE, data_space_used_);
21 deserializer->set_reservation(CODE_SPACE, code_space_used_); 21 deserializer->AddReservation(CODE_SPACE, code_space_used_);
22 deserializer->set_reservation(MAP_SPACE, map_space_used_); 22 deserializer->AddReservation(MAP_SPACE, map_space_used_);
23 deserializer->set_reservation(CELL_SPACE, cell_space_used_); 23 deserializer->AddReservation(CELL_SPACE, cell_space_used_);
24 deserializer->set_reservation(PROPERTY_CELL_SPACE, property_cell_space_used_); 24 deserializer->AddReservation(PROPERTY_CELL_SPACE, property_cell_space_used_);
25 deserializer->set_reservation(LO_SPACE, lo_space_used_); 25 deserializer->AddReservation(LO_SPACE, lo_space_used_);
26 } 26 }
27 27
28 28
29 bool Snapshot::Initialize(Isolate* isolate) { 29 bool Snapshot::Initialize(Isolate* isolate) {
30 if (size_ > 0) { 30 if (size_ > 0) {
31 base::ElapsedTimer timer; 31 base::ElapsedTimer timer;
32 if (FLAG_profile_deserialization) { 32 if (FLAG_profile_deserialization) {
33 timer.Start(); 33 timer.Start();
34 } 34 }
35 SnapshotByteSource source(raw_data_, raw_size_); 35 SnapshotByteSource source(raw_data_, raw_size_);
(...skipping 16 matching lines...) Expand all
52 52
53 53
54 Handle<Context> Snapshot::NewContextFromSnapshot(Isolate* isolate) { 54 Handle<Context> Snapshot::NewContextFromSnapshot(Isolate* isolate) {
55 if (context_size_ == 0) { 55 if (context_size_ == 0) {
56 return Handle<Context>(); 56 return Handle<Context>();
57 } 57 }
58 SnapshotByteSource source(context_raw_data_, 58 SnapshotByteSource source(context_raw_data_,
59 context_raw_size_); 59 context_raw_size_);
60 Deserializer deserializer(&source); 60 Deserializer deserializer(&source);
61 Object* root; 61 Object* root;
62 deserializer.set_reservation(NEW_SPACE, context_new_space_used_); 62 deserializer.AddReservation(NEW_SPACE, context_new_space_used_);
63 deserializer.set_reservation(OLD_POINTER_SPACE, context_pointer_space_used_); 63 deserializer.AddReservation(OLD_POINTER_SPACE, context_pointer_space_used_);
64 deserializer.set_reservation(OLD_DATA_SPACE, context_data_space_used_); 64 deserializer.AddReservation(OLD_DATA_SPACE, context_data_space_used_);
65 deserializer.set_reservation(CODE_SPACE, context_code_space_used_); 65 deserializer.AddReservation(CODE_SPACE, context_code_space_used_);
66 deserializer.set_reservation(MAP_SPACE, context_map_space_used_); 66 deserializer.AddReservation(MAP_SPACE, context_map_space_used_);
67 deserializer.set_reservation(CELL_SPACE, context_cell_space_used_); 67 deserializer.AddReservation(CELL_SPACE, context_cell_space_used_);
68 deserializer.set_reservation(PROPERTY_CELL_SPACE, 68 deserializer.AddReservation(PROPERTY_CELL_SPACE,
69 context_property_cell_space_used_); 69 context_property_cell_space_used_);
70 deserializer.set_reservation(LO_SPACE, context_lo_space_used_); 70 deserializer.AddReservation(LO_SPACE, context_lo_space_used_);
71 deserializer.DeserializePartial(isolate, &root); 71 deserializer.DeserializePartial(isolate, &root);
72 CHECK(root->IsContext()); 72 CHECK(root->IsContext());
73 return Handle<Context>(Context::cast(root)); 73 return Handle<Context>(Context::cast(root));
74 } 74 }
75 75
76 76
77 #ifdef V8_USE_EXTERNAL_STARTUP_DATA 77 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
78 // Dummy implementations of Set*FromFile(..) APIs. 78 // Dummy implementations of Set*FromFile(..) APIs.
79 // 79 //
80 // These are meant for use with snapshot-external.cc. Should this file 80 // These are meant for use with snapshot-external.cc. Should this file
81 // be compiled with those options we just supply these dummy implementations 81 // be compiled with those options we just supply these dummy implementations
82 // below. This happens when compiling the mksnapshot utility. 82 // below. This happens when compiling the mksnapshot utility.
83 void SetNativesFromFile(StartupData* data) { CHECK(false); } 83 void SetNativesFromFile(StartupData* data) { CHECK(false); }
84 void SetSnapshotFromFile(StartupData* data) { CHECK(false); } 84 void SetSnapshotFromFile(StartupData* data) { CHECK(false); }
85 #endif // V8_USE_EXTERNAL_STARTUP_DATA 85 #endif // V8_USE_EXTERNAL_STARTUP_DATA
86 86
87 } } // namespace v8::internal 87 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/serialize.cc ('k') | src/snapshot-external.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698