Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 652843002: Revert of Create a single command buffer for GrInOrderDrawBuffer (Closed)

Created:
6 years, 2 months ago by mtklein
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Create a single command buffer for GrInOrderDrawBuffer (patchset #14 id:1050001 of https://codereview.chromium.org/628453002/) Reason for revert: New test failing on Android: http://build.chromium.org/p/client.skia.android/builders/Test-Android-Nexus7-Tegra3-Arm7-Release/builds/89/steps/dm/logs/stdio Original issue's description: > Adds a GrTBaseList class that GrInOrderDrawBuffer uses to allocate > all its commands interleaved in contiguous memory. GrTBaseList also > supports extra data associated with objects, so we can store arrays > inline without having to call malloc(). > > Committed: https://skia.googlesource.com/skia/+/47c844aaba81e5a29c773b660e1d6062c766d253 TBR=bsalomon@google.com,reed@google.com,cdalton@nvidia.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/07894c4d7dbd539583d7f51f05616e295eef2578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -724 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 8 chunks +78 lines, -82 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 14 chunks +222 lines, -145 lines 0 comments Download
D src/gpu/GrTRecorder.h View 1 chunk +0 lines, -251 lines 0 comments Download
D tests/GrTRecorderTest.cpp View 1 chunk +0 lines, -244 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of Create a single command buffer for GrInOrderDrawBuffer
6 years, 2 months ago (2014-10-13 20:59:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652843002/1
6 years, 2 months ago (2014-10-13 21:00:28 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 21:00:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 07894c4d7dbd539583d7f51f05616e295eef2578

Powered by Google App Engine
This is Rietveld 408576698