Expose WebCore log channels on the chrome command line

Expose WebCore log channels on the chrome command line

Add --webcore-log-channels=Loading,ResourceLoading to your chrome
command line to get WebKit debugging joy.  See
third_party/WebKit/Source/WebCore/platform/Logging.cpp for a list
of log levels.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75117

[gavinp, 2011-02-15 16:57:59]

I have been hosting my webkit work in Chrome a lot lately (now that WebKit git
works so well with Chrome, it's kind of awesome).  But I found I was hard coding
log enabling; this should help avoid that.

[abarth-chromium, 2011-02-15 19:31:34]

This looks reasonable as far as I can tell, but I don't really know much about
the logging system.  I'm not sure who to recommend reviews this patch.

[gavinp, 2011-02-15 19:48:06]

+ Darin

Darin,

You wrote the interface in WebKit::enableLogChannel that I'm using here.  The
blame in webkit_glue.cc and renderer_thread.cc pointed at you too in the
relevant f'ns.

Can you review this CL please?

[darin (slow to review), 2011-02-15 20:54:55]

http://codereview.chromium.org/6528016/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/6528016/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:1237: //
third_party/WebKit/Source/WebCore/platform/Logging.cpp for a list of
this comment runs the risk of bit-rotting.  if someone moves that file in
WebCore, they surely won't think of fixing this comment!  that said, this
comment is definitely useful as one would like to know where to look for the
various log channel definitions.

http://codereview.chromium.org/6528016/diff/1/webkit/glue/webkit_glue.cc
File webkit/glue/webkit_glue.cc (right):

http://codereview.chromium.org/6528016/diff/1/webkit/glue/webkit_glue.cc#newc...
webkit/glue/webkit_glue.cc:87: size_t elem_end = channels.find(',');
i think you should be using StringSplit or StringTokenizer here instead of
rolling your own.

[gavinp, 2011-02-15 21:25:48]

Thanks for the review Darin!

http://codereview.chromium.org/6528016/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/6528016/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:1237: //
third_party/WebKit/Source/WebCore/platform/Logging.cpp for a list of
On 2011/02/15 20:54:56, darin wrote:
> this comment runs the risk of bit-rotting.  if someone moves that file in
> WebCore, they surely won't think of fixing this comment!  that said, this
> comment is definitely useful as one would like to know where to look for the
> various log channel definitions.

I made the comment less specific, so at least it'll rot more gracefully. 
Without something like this, it's hard to know what your options are, although I
anticipate most users will already have seen what they want in the WebKit
source.

http://codereview.chromium.org/6528016/diff/1/webkit/glue/webkit_glue.cc
File webkit/glue/webkit_glue.cc (right):

http://codereview.chromium.org/6528016/diff/1/webkit/glue/webkit_glue.cc#newc...
webkit/glue/webkit_glue.cc:87: size_t elem_end = channels.find(',');
On 2011/02/15 20:54:56, darin wrote:
> i think you should be using StringSplit or StringTokenizer here instead of
> rolling your own.

Done.

[darin (slow to review), 2011-02-16 00:52:16]

LGTM