Expose WebCore log channels on the chrome command line

webkit/glue/webkit_glue.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/webkit_glue.h"
 
 #if defined(OS_WIN)
 #include <objidl.h>
 #include <mlang.h>
 #elif defined(OS_POSIX) && !defined(OS_MACOSX)
@@ skipping 62 matching lines @@
 
 // Global variable used by the plugin quirk "die after unload".
 bool g_forcefully_terminate_plugin_process = false;
 
 void SetJavaScriptFlags(const std::string& str) {
 #if WEBKIT_USING_V8
   v8::V8::SetFlagsFromString(str.data(), static_cast<int>(str.size()));
 #endif
 }
 
-void EnableWebCoreNotImplementedLogging() {
-  WebKit::enableLogChannel("NotYetImplemented");
+void EnableWebCoreLogChannels(const std::string& channels) {
+  if (channels.empty())
+    return;
+  size_t elem_begin = 0;
+  size_t elem_end = channels.find(',');

[darin (slow to review), 2011/02/15 20:54:56]

i think you should be using StringSplit or StringTokenizer here instead of
rolling your own.

[gavinp, 2011/02/15 21:25:48]

Done.

+  while (true) {
+    const std::string elem(channels, elem_begin, elem_end);
+    WebKit::enableLogChannel(elem.c_str());
+    if (elem_end == std::string::npos)
+      break;
+    elem_begin = elem_end + 1;
+    elem_end = channels.find(',', elem_begin);
+  }
 }
 
 string16 DumpDocumentText(WebFrame* web_frame) {
   // We use the document element's text instead of the body text here because
   // not all documents have a body, such as XML documents.
   WebElement document_element = web_frame->document().documentElement();
   if (document_element.isNull())
     return string16();
 
   return document_element.innerText();
@@ skipping 310 matching lines @@
   NOTIMPLEMENTED();
   return NULL;
 #endif
 }
 
 int GetGlyphPageCount() {
   return WebGlyphCache::pageCount();
 }
 
 } // namespace webkit_glue