Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 652783002: Revert of Exclude readonly and disabled elements from autofill form. (Closed)

Created:
6 years, 2 months ago by Evan Stade
Modified:
6 years, 2 months ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Exclude readonly and disabled elements from autofill form. (patchset #3 id:40001 of https://codereview.chromium.org/621503003/) Reason for revert: breaks requestAutocomplete Original issue's description: > Exclude readonly and disabled elements from autofill form. > > R=isherman@chromium.org > BUG=231160 > > Committed: https://crrev.com/cfe1912bcc70118364c9156e1e12c6c89b1a06b9 > Cr-Commit-Position: refs/heads/master@{#298436} TBR=isherman@chromium.org,mkwst@chromium.org,ziran.sun@samsung.com NOTREECHECKS=true NOTRY=true BUG=231160 Committed: https://crrev.com/2bd42c07f44b7c5d8cdfb858c713499bb9fd120c Cr-Commit-Position: refs/heads/master@{#299328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -14 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 5 chunks +28 lines, -10 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/02_checkout_cafepress.com.out View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_aol.com.out View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/09_register_google.com.out View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_myspace.com.out View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/15_crbug_40687.out View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
Created Revert of Exclude readonly and disabled elements from autofill form.
6 years, 2 months ago (2014-10-13 18:31:03 UTC) #1
Mike West
Is there a test for the rAc functionality it breaks?
6 years, 2 months ago (2014-10-13 18:32:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652783002/1
6 years, 2 months ago (2014-10-13 18:32:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 18:34:12 UTC) #4
Evan Stade
On 2014/10/13 18:32:40, Mike West wrote: > Is there a test for the rAc functionality ...
6 years, 2 months ago (2014-10-13 18:34:26 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 18:35:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2bd42c07f44b7c5d8cdfb858c713499bb9fd120c
Cr-Commit-Position: refs/heads/master@{#299328}

Powered by Google App Engine
This is Rietveld 408576698