Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 652733002: Added a bit more high-level documentation to android power monitors. Explained what ds2784 is and w… (Closed)

Created:
6 years, 2 months ago by sullivan
Modified:
6 years, 2 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, dtu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added a bit more high-level documentation to android power monitors. Explained what ds2784 is and what android releases the data is available on. BUG= Committed: https://crrev.com/acb42d605a553b12daa6c2719a0072b2f67a9d6f Cr-Commit-Position: refs/heads/master@{#299311}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Clarified ds2784 comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sullivan
Please let me know if I got anything wrong or there is a better way ...
6 years, 2 months ago (2014-10-13 15:31:41 UTC) #2
tonyg
lgtm https://codereview.chromium.org/652733002/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py (right): https://codereview.chromium.org/652733002/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py#newcode22 tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py:22: """PowerMonitor that relies on the ds2784 fuel gauge ...
6 years, 2 months ago (2014-10-13 16:01:12 UTC) #3
sullivan
https://codereview.chromium.org/652733002/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py File tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py (right): https://codereview.chromium.org/652733002/diff/1/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py#newcode22 tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py:22: """PowerMonitor that relies on the ds2784 fuel gauge chip ...
6 years, 2 months ago (2014-10-13 16:15:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652733002/70001
6 years, 2 months ago (2014-10-13 16:16:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:70001)
6 years, 2 months ago (2014-10-13 17:11:52 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 17:12:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/acb42d605a553b12daa6c2719a0072b2f67a9d6f
Cr-Commit-Position: refs/heads/master@{#299311}

Powered by Google App Engine
This is Rietveld 408576698