tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py - Issue 652733002: Added a bit more high-level documentation to android power monitors. Explained what ds2784 is and w…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

Issue 652733002: Added a bit more high-level documentation to android power monitors. Explained what ds2784 is and w… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarified ds2784 comment Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

index 06883481e05b6f2616054219cde98b66cea43ce8..8bfef440837bf855a78982009b55204f7b3b8295 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/android_ds2784_power_monitor.py

@@ -19,6 +19,11 @@ VOLTAGE = os.path.join(FUEL_GAUGE_PATH, 'voltage_now')

class DS2784PowerMonitor(sysfs_power_monitor.SysfsPowerMonitor):

+ """PowerMonitor that relies on the ds2784 fuel gauge chip.

+ The ds2784 chip is in some Android devices, for example the nexus 10.

+ This gives reliable energy numbers on Android L and higher releases.

+ """

def __init__(self, device, platform_backend):

super(DS2784PowerMonitor, self).__init__(platform_backend)

self._device = device

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/platform/power_monitor/android_dumpsys_power_monitor.py » ('j') | no next file with comments »