Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 652693002: Replace FINAL and OVERRIDE with their C++11 counterparts in WebKit/Source (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in WebKit/Source This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183614

Patch Set 1 #

Patch Set 2 : Corrected the Patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M Source/core/frame/RemoteFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderText.h View 6 chunks +23 lines, -23 lines 0 comments Download
M Source/modules/bluetooth/NavigatorBluetooth.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupMenuChromium.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-13 12:57:17 UTC) #2
MRV
On 2014/10/13 12:57:17, MRV wrote: > PTAL Dear Mr. Mike, This will final patch, which ...
6 years, 2 months ago (2014-10-13 13:28:51 UTC) #3
Mike West
LGTM.
6 years, 2 months ago (2014-10-13 13:29:05 UTC) #4
MRV
On 2014/10/13 13:29:05, Mike West wrote: > LGTM. Thanks Mr. Mike for review.
6 years, 2 months ago (2014-10-13 13:29:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652693002/90001
6 years, 2 months ago (2014-10-13 13:30:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31508)
6 years, 2 months ago (2014-10-13 15:43:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652693002/90001
6 years, 2 months ago (2014-10-13 16:02:27 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 16:43:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:90001) as 183614

Powered by Google App Engine
This is Rietveld 408576698