Fix Java Checkstyle issues.

Fix Java Checkstyle issues.

After this change we are down to:
- 3 redundant import warnings (due to JNI generator)
- 69 JavaDoc warnings

BUG=318404
R=agl@chromium.org, blundell@chromium.org, boliu@chromium.org, lambroslambrou@chromium.org, nyquist@chromium.org, qinmin@chromium.org, rmcilroy@chromium.org, tedchoc@chromium.org
TBR=yfriedman@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/e8941c4b0003ce7f6e6c8ceaf9c322177e74548e

[aurimas (slooooooooow), 2014-10-13 20:53:27]

aurimas@chromium.org changed reviewers:
+ boliu@chromium.org, lambroslambrou@chromium.org, qinmin@chromium.org,
rmcilroy@chromium.org, tedchoc@chromium.org

[aurimas (slooooooooow), 2014-10-13 20:53:28]

qinmin@chromium.org: Please review changes in 
media/

boliu@chromium.org: Please review changes in 
android_webview/

rmcilroy@chromium.org: Please review changes in 
base/

tedchoc@chromium.org: Please review changes in 
content/ and ui/

lambroslambrou@chromium.org: Please review changes in 
remoting/

[Ted C, 2014-10-13 21:02:03]

content && ui - lgtm

https://chromiumcodereview.appspot.com/652603004/diff/310001/content/public/a...
File
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java
(right):

https://chromiumcodereview.appspot.com/652603004/diff/310001/content/public/a...
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:292:
return values;
since you're here, can you add braces or move this up?

[Lambros, 2014-10-13 21:07:11]

remoting/ LGTM

[qinmin, 2014-10-13 21:24:02]

media/ lgtm

[boliu, 2014-10-13 21:31:48]

android_webview lgtm

[aurimas (slooooooooow), 2014-10-13 22:51:52]

https://chromiumcodereview.appspot.com/652603004/diff/310001/content/public/a...
File
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java
(right):

https://chromiumcodereview.appspot.com/652603004/diff/310001/content/public/a...
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:292:
return values;
On 2014/10/13 21:02:03, Ted C wrote:
> since you're here, can you add braces or move this up?

Done.

[aurimas (slooooooooow), 2014-10-13 23:13:27]

aurimas@chromium.org changed reviewers:
+ agl@chromium.org, blundell@chromium.org, nyquist@chromium.org

[aurimas (slooooooooow), 2014-10-13 23:14:38]

Please take a look:

blundell@chromium.org
components/

agl@chromium.org
net/

nyquist@chromium.org
sync/ and base/

[riju_, 2014-10-14 06:25:57]

rijubrata.bhaumik@intel.com changed reviewers:
+ rijubrata.bhaumik@intel.com

[riju_, 2014-10-14 06:25:58]

https://chromiumcodereview.appspot.com/652603004/diff/440001/content/public/a...
File
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java
(right):

https://chromiumcodereview.appspot.com/652603004/diff/440001/content/public/a...
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:274:
* @param r
Please check with Tim for this change. 
Have a look at crrev.com/591383002

[blundell, 2014-10-14 06:55:01]

//components RS LGTM

[rmcilroy, 2014-10-14 07:53:46]

On 2014/10/14 06:55:01, blundell wrote:
> //components RS LGTM

Base lgtm.

[timvolodine, 2014-10-14 13:12:57]

timvolodine@chromium.org changed reviewers:
+ timvolodine@chromium.org

[timvolodine, 2014-10-14 13:12:57]

https://chromiumcodereview.appspot.com/652603004/diff/440001/content/public/a...
File
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java
(right):

https://chromiumcodereview.appspot.com/652603004/diff/440001/content/public/a...
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:274:
* @param r
On 2014/10/14 06:25:58, riju_ wrote:
> Please check with Tim for this change. 
> Have a look at crrev.com/591383002 

The use of R was to make code consistent with Android, e.g. see
SensorManager.java getRotationMatrix and others where a capital letter is used
to denote a matrix. IMHO making it "r" is confusing and somewhat breaks the
existing comments.

[aurimas (slooooooooow), 2014-10-14 14:48:17]

https://chromiumcodereview.appspot.com/652603004/diff/440001/content/public/a...
File
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java
(right):

https://chromiumcodereview.appspot.com/652603004/diff/440001/content/public/a...
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:274:
* @param r
On 2014/10/14 13:12:57, timvolodine wrote:
> On 2014/10/14 06:25:58, riju_ wrote:
> > Please check with Tim for this change. 
> > Have a look at crrev.com/591383002 
> 
> The use of R was to make code consistent with Android, e.g. see
> SensorManager.java getRotationMatrix and others where a capital letter is used
> to denote a matrix. IMHO making it "r" is confusing and somewhat breaks the
> existing comments.

According to the style guide the method parameter names have to be
lowerCamelCase.
https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s5.2.6-para...

Should I rename it to R to matrix? Or do you have better suggestions? I can
update all the comments for this method too.

[nyquist, 2014-10-14 16:07:45]

https://chromiumcodereview.appspot.com/652603004/diff/440001/base/android/jav...
File base/android/java/templates/NativeLibraries.template (right):

https://chromiumcodereview.appspot.com/652603004/diff/440001/base/android/jav...
base/android/java/templates/NativeLibraries.template:52: public static boolean
sUseLinker = true;
Could you make these bools final instead? That would keep the casing intact as
well.

I'm not an owner for android_webview, but whatever you decide, I believe we
should try to use the same
inandroid_webview/java/generated_src/org/chromium/base/library_loader/NativeLibraries.java

Also, I guess 
build/android/tests/multiple_proguards/src/dummy/NativeLibraries.java should be
the same.

https://chromiumcodereview.appspot.com/652603004/diff/440001/base/android/jav...
base/android/java/templates/NativeLibraries.template:86: static String
sVersionNumber =
I think this also can be final, at which point I believe at least the intention
is that it is constant, i.e. keep casing as uppercase.

[nyquist, 2014-10-14 16:23:05]

disregard me. sorry.

lgtm!

[timvolodine, 2014-10-14 16:29:40]

https://chromiumcodereview.appspot.com/652603004/diff/440001/content/public/a...
File
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java
(right):

https://chromiumcodereview.appspot.com/652603004/diff/440001/content/public/a...
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:274:
* @param r
On 2014/10/14 14:48:17, aurimas wrote:
> On 2014/10/14 13:12:57, timvolodine wrote:
> > On 2014/10/14 06:25:58, riju_ wrote:
> > > Please check with Tim for this change. 
> > > Have a look at crrev.com/591383002 
> > 
> > The use of R was to make code consistent with Android, e.g. see
> > SensorManager.java getRotationMatrix and others where a capital letter is
used
> > to denote a matrix. IMHO making it "r" is confusing and somewhat breaks the
> > existing comments.
> 
> According to the style guide the method parameter names have to be
> lowerCamelCase.
>
https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s5.2.6-para...
> 
> Should I rename it to R to matrix? Or do you have better suggestions? I can
> update all the comments for this method too.

I would argue for an exception for math functions ;), but if you want to get rid
of one-char parameter name then "matrix" sounds like a reasonable alternative.

[aurimas (slooooooooow), 2014-10-14 16:38:01]

https://chromiumcodereview.appspot.com/652603004/diff/440001/content/public/a...
File
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java
(right):

https://chromiumcodereview.appspot.com/652603004/diff/440001/content/public/a...
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:274:
* @param r
On 2014/10/14 16:29:40, timvolodine wrote:
> On 2014/10/14 14:48:17, aurimas wrote:
> > On 2014/10/14 13:12:57, timvolodine wrote:
> > > On 2014/10/14 06:25:58, riju_ wrote:
> > > > Please check with Tim for this change. 
> > > > Have a look at crrev.com/591383002 
> > > 
> > > The use of R was to make code consistent with Android, e.g. see
> > > SensorManager.java getRotationMatrix and others where a capital letter is
> used
> > > to denote a matrix. IMHO making it "r" is confusing and somewhat breaks
the
> > > existing comments.
> > 
> > According to the style guide the method parameter names have to be
> > lowerCamelCase.
> >
>
https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s5.2.6-para...
> > 
> > Should I rename it to R to matrix? Or do you have better suggestions? I can
> > update all the comments for this method too.
> 
> I would argue for an exception for math functions ;), but if you want to get
rid
> of one-char parameter name then "matrix" sounds like a reasonable alternative.

I agree that it is kind of silly, but this is the only case with an upper case
method parameter name in entire code base and it would suck if we could not
enable this style check just because of it :/

[aurimas (slooooooooow), 2014-10-14 17:26:59]

https://chromiumcodereview.appspot.com/652603004/diff/490001/content/public/a...
File
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java
(right):

https://chromiumcodereview.appspot.com/652603004/diff/490001/content/public/a...
content/public/android/java/src/org/chromium/content/browser/DeviceSensors.java:284:
float[] matrixR, double[] values) {
Renamed this to matrixR

[aurimas (slooooooooow), 2014-10-14 18:32:13]

aurimas@chromium.org changed reviewers:
+ yfriedman@chromium.org

[aurimas (slooooooooow), 2014-10-14 18:32:19]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-10-14 18:33:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/652603004/490001

[agl, 2014-10-14 18:34:32]

net/ LGTM.

[commit-bot: I haz the power, 2014-10-14 18:42:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 18:42:19]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-10-14 20:42:12]

Patchset 4 (id:??) landed as
https://crrev.com/e8941c4b0003ce7f6e6c8ceaf9c322177e74548e
Cr-Commit-Position: refs/heads/master@{#299540}

[aurimas (slooooooooow), 2014-10-14 20:42:14]

Committed patchset #4 (id:490001) manually as
e8941c4b0003ce7f6e6c8ceaf9c322177e74548e (presubmit successful).