Issue 652363006: [turbofan] First step towards correctified 64-bit addressing.

Issue 652363006: [turbofan] First step towards correctified 64-bit addressing. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
dcarney

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] First step towards correctified 64-bit addressing. Also remove the LEA matching from x64, since it was never really effective. We'll optimize that once we're correct. TEST=cctest,unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25024

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes #

Patch Set 3 : Fixes2 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+500 lines, -791 lines)			Patch
M	BUILD.gn	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/compiler/change-lowering.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/compiler/ia32/instruction-selector-ia32.cc	View	1	1 chunk	+172 lines, -0 lines	0 comments	Download
M	src/compiler/instruction.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/compiler/machine-type.h	View	1 2	1 chunk	+17 lines, -9 lines	0 comments	Download
M	src/compiler/node-matchers.h	View		1 chunk	+0 lines, -82 lines	0 comments	Download
M	src/compiler/node-matchers.cc	View	1 2	1 chunk	+0 lines, -104 lines	0 comments	Download
M	src/compiler/simplified-lowering.cc	View	1	3 chunks	+13 lines, -11 lines	0 comments	Download
M	src/compiler/x64/code-generator-x64.cc	View	1	1 chunk	+1 line, -6 lines	0 comments	Download
M	src/compiler/x64/instruction-codes-x64.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View	1	13 chunks	+112 lines, -200 lines	0 comments	Download
M	test/cctest/compiler/test-simplified-lowering.cc	View	1	8 chunks	+44 lines, -35 lines	0 comments	Download
M	test/unittests/compiler/change-lowering-unittest.cc	View		8 chunks	+16 lines, -13 lines	0 comments	Download
M	test/unittests/compiler/instruction-selector-unittest.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/unittests/compiler/instruction-selector-unittest.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/x64/instruction-selector-x64-unittest.cc	View		3 chunks	+106 lines, -321 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dcarney

lgtm https://codereview.chromium.org/652363006/diff/1/src/compiler/node-matchers.cc File src/compiler/node-matchers.cc (left): https://codereview.chromium.org/652363006/diff/1/src/compiler/node-matchers.cc#oldcode11 src/compiler/node-matchers.cc:11: delete this file?

6 years, 1 month ago (2014-10-30 12:34:39 UTC) #3

Benedikt Meurer

https://codereview.chromium.org/652363006/diff/1/src/compiler/node-matchers.cc File src/compiler/node-matchers.cc (left): https://codereview.chromium.org/652363006/diff/1/src/compiler/node-matchers.cc#oldcode11 src/compiler/node-matchers.cc:11: On 2014/10/30 12:34:39, dcarney wrote: > delete this file? ...

6 years, 1 month ago (2014-10-31 06:14:57 UTC) #4

Benedikt Meurer

6 years, 1 month ago (2014-10-31 06:41:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 25024 (presubmit successful).

Expand Messages | Collapse Messages