src/compiler/instruction.h - Issue 652363006: [turbofan] First step towards correctified 64-bit addressing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/instruction.h

Issue 652363006: [turbofan] First step towards correctified 64-bit addressing. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fixes2 Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/instruction.h

diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h

index 6d37b9f6932eec59d0c78e8db3db8687c137f0cb..75c3e9e34b0f94c0f1fc6fbe51e8d9727c2df756 100644

--- a/src/compiler/instruction.h

+++ b/src/compiler/instruction.h

@@ -675,8 +675,10 @@ class Constant FINAL {

Type type() const { return type_; }

int32_t ToInt32() const {

- DCHECK_EQ(kInt32, type());

- return static_cast<int32_t>(value_);

+ DCHECK(type() == kInt32 || type() == kInt64);

+ const int32_t value = static_cast<int32_t>(value_);

+ DCHECK_EQ(value_, static_cast<int64_t>(value));

+ return value;

}

int64_t ToInt64() const {

« no previous file with comments | « src/compiler/ia32/instruction-selector-ia32.cc ('k') | src/compiler/machine-type.h » ('j') | no next file with comments »