content/common/frame_messages.h - Issue 652283002: Navigation transitions (web to native app): Get names and rects of transition elements (Chrome side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 652283002: Navigation transitions (web to native app): Get names and rects of transition elements (Chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use struct as IPC params Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/transition_request_manager.cc ('K') | « content/browser/web_contents/web_contents_android.cc ('k') | content/renderer/render_frame_impl.h » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index cb8a37e391fd3b4a9d19f9206964fbf3afb9cb2f..8e1213d4f803ca75d4dea7a4dbce39dfba417614 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -262,6 +262,15 @@ IPC_STRUCT_BEGIN(FrameMsg_Navigate_Params)

IPC_STRUCT_MEMBER(std::string, frame_to_navigate)

IPC_STRUCT_END()

+IPC_STRUCT_BEGIN(FrameHostMsg_AddNavigationTransitionData_Params)

+ IPC_STRUCT_MEMBER(int, render_frame_id)

+ IPC_STRUCT_MEMBER(std::string, allowed_destination_host_pattern)

+ IPC_STRUCT_MEMBER(std::string, selector)

+ IPC_STRUCT_MEMBER(std::string, markup)

+ IPC_STRUCT_MEMBER(std::vector<std::string>, names)

+ IPC_STRUCT_MEMBER(std::vector<gfx::Rect>, rects)

+IPC_STRUCT_END()

IPC_STRUCT_BEGIN(FrameHostMsg_OpenURL_Params)

IPC_STRUCT_MEMBER(GURL, url)

IPC_STRUCT_MEMBER(content::Referrer, referrer)

@@ -732,11 +741,8 @@ IPC_MESSAGE_ROUTED3(FrameHostMsg_TextSurroundingSelectionResponse,

// Notifies the browser that the renderer has a pending navigation transition.

// The string parameters are all UTF8.

-IPC_MESSAGE_CONTROL4(FrameHostMsg_AddNavigationTransitionData,

- int /* render_frame_id */,

- std::string /* allowed_destination_host_pattern */,

- std::string /* selector */,

- std::string /* markup */)

+IPC_MESSAGE_CONTROL1(FrameHostMsg_AddNavigationTransitionData,

+ FrameHostMsg_AddNavigationTransitionData_Params)

// PlzNavigate

// Tells the browser to perform a navigation.