content/browser/web_contents/web_contents_android.cc - Issue 652283002: Navigation transitions (web to native app): Get names and rects of transition elements (Chrome side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_android.cc

Issue 652283002: Navigation transitions (web to native app): Get names and rects of transition elements (Chrome side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use struct as IPC params Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/transition_request_manager.cc ('K') | « content/browser/transition_request_manager.cc ('k') | content/common/frame_messages.h » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_android.cc

diff --git a/content/browser/web_contents/web_contents_android.cc b/content/browser/web_contents/web_contents_android.cc

index 52702a412e4212ed0f6eb4f096851554f3345f16..1bef8a3c293fc4e4874296fb7f62aac40b68f9ae 100644

--- a/content/browser/web_contents/web_contents_android.cc

+++ b/content/browser/web_contents/web_contents_android.cc

@@ -151,13 +151,11 @@ void WebContentsAndroid::SetHasPendingNavigationTransitionForTesting(

BrowserThread::PostTask(

BrowserThread::IO,

FROM_HERE,

- base::Bind(&TransitionRequestManager::AddPendingTransitionRequestData,

- base::Unretained(TransitionRequestManager::GetInstance()),

- frame->GetProcess()->GetID(),

- frame->GetRoutingID(),

- "*",

- "",

- ""));

+ base::Bind(

+ &TransitionRequestManager::AddPendingTransitionRequestDataForTesting,

+ base::Unretained(TransitionRequestManager::GetInstance()),

+ frame->GetProcess()->GetID(),

+ frame->GetRoutingID()));

}

void WebContentsAndroid::SetupTransitionView(JNIEnv* env,