Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 652193005: Fix more flaky autofill tests. (Closed)

Created:
6 years, 2 months ago by Evan Stade
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix more flaky autofill tests. These were flaky because we changed to returning profiles in reverse chronological order: https://codereview.chromium.org/600873002 The tests assumed normal chronological order. It only failed sometimes because frequently two items would get inserted with the same timestamp, so ordering fell back to GUID. Thus by placing sleep(1) in between AddProfile calls, the flaky failures become consistent failures. BUG=420023 Committed: https://crrev.com/69b952cfdb40656f47a50d0202263521de1ffe19 Cr-Commit-Position: refs/heads/master@{#299784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -25 lines) Patch
M components/autofill/core/browser/webdata/web_data_service_unittest.cc View 6 chunks +18 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Evan Stade
6 years, 2 months ago (2014-10-15 00:19:34 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 2 months ago (2014-10-15 00:20:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652193005/1
6 years, 2 months ago (2014-10-15 00:22:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/18352)
6 years, 2 months ago (2014-10-15 01:11:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652193005/1
6 years, 2 months ago (2014-10-15 23:03:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-15 23:25:18 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 23:26:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69b952cfdb40656f47a50d0202263521de1ffe19
Cr-Commit-Position: refs/heads/master@{#299784}

Powered by Google App Engine
This is Rietveld 408576698