Order returning profiles and card by descending date_modified

Order returning profiles and card by descending date_modified

The unittests (WebDataServiceAutofillTest.CreditUpdate) assume that the
newly modified credit card information will be the first one returned.
Since it has the highest date_modified value, this imply a descending
ordering of the cards when iterating.

The unittests were previously flaky as the precision of date_modified
is not high enough and both card ended up with the same value most of
the time. When the test was taking slightly more time to run, then the
modified car would end up last and the test would fail.

BUG=None

Committed: https://crrev.com/32977338f1cd4b588d4244e49860f35bdda7c3a6
Cr-Commit-Position: refs/heads/master@{#296623}

[sdefresne, 2014-09-24 15:03:30]

sdefresne@chromium.org changed reviewers:
+ isherman@chromium.org

[sdefresne, 2014-09-24 15:03:31]

Please have a look.

Example of a test failure (internal bot):

WebDataServiceAutofillTest.CreditUpdate:
components/autofill/core/browser/webdata/web_data_service_unittest.cc:479:
Failure
Value of: *consumer2.result()[0]
  Actual: Alice E4D2662E-5E16-44F3-AF5A-5A77FAE4A6F3 https://example.com Alice
Expected: card1_changed
Which is: Bill B9C52112-BD5F-4080-84E1-C651D2CB90E2 https://ejemplo.mx Bill
components/autofill/core/browser/webdata/web_data_service_unittest.cc:480:
Failure
Value of: *consumer2.result()[1]
  Actual: Bill B9C52112-BD5F-4080-84E1-C651D2CB90E2 https://ejemplo.mx Bill
Expected: card2
Which is: Alice E4D2662E-5E16-44F3-AF5A-5A77FAE4A6F3 https://example.com Alice

[sdefresne, 2014-09-24 15:12:09]

sdefresne@chromium.org changed reviewers:
+ jimblackler@chromium.org

[sdefresne, 2014-09-24 15:12:51]

+ jimblackler: can you take a look as you know autofill?

[Evan Stade, 2014-09-24 22:03:59]

ah, this is my fault, sorry. This change also affects the ordering in the UI,
chrome://settings/autofill for example. But that seems ok to me.

lgtm

[Ilya Sherman, 2014-09-24 23:08:07]

Could you please also update AutofillTable::GetAutofillProfiles()?  LGTM with
that change.  Thanks.

[Evan Stade, 2014-09-24 23:20:24]

On 2014/09/24 23:08:07, Ilya Sherman wrote:
> Could you please also update AutofillTable::GetAutofillProfiles()?  LGTM with
> that change.  Thanks.

I believe the function was already updated

[Ilya Sherman, 2014-09-24 23:40:06]

On 2014/09/24 23:20:24, Evan Stade wrote:
> On 2014/09/24 23:08:07, Ilya Sherman wrote:
> > Could you please also update AutofillTable::GetAutofillProfiles()?  LGTM
with
> > that change.  Thanks.
> 
> I believe the function was already updated

Hmm, really?  It doesn't look like it on tip of tree...

[Evan Stade, 2014-09-25 00:00:05]

estade@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2014-09-25 00:00:06]

https://codereview.chromium.org/600873002/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/webdata/autofill_table.cc (right):

https://codereview.chromium.org/600873002/diff/1/components/autofill/core/bro...
components/autofill/core/browser/webdata/autofill_table.cc:933: "ORDER BY
date_modified DESC, guid"));
I meant here, not on trunk

[Ilya Sherman, 2014-09-25 00:08:55]

https://codereview.chromium.org/600873002/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/webdata/autofill_table.cc (right):

https://codereview.chromium.org/600873002/diff/1/components/autofill/core/bro...
components/autofill/core/browser/webdata/autofill_table.cc:933: "ORDER BY
date_modified DESC, guid"));
On 2014/09/25 00:00:06, Evan Stade wrote:
> I meant here, not on trunk

Oh, I have no idea how I missed that.  My bad.

[Evan Stade, 2014-09-25 00:20:21]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2014-09-25 00:20:51]

I'll just go ahead and CQ now since it's flakily breaking some bots.

[commit-bot: I haz the power, 2014-09-25 00:21:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/600873002/1

[commit-bot: I haz the power, 2014-09-25 02:05:39]

Committed patchset #1 (id:1) as f2745ca4053e2baed533b08ad51b238d143711b0

[commit-bot: I haz the power, 2014-09-25 02:06:22]

Patchset 1 (id:??) landed as
https://crrev.com/32977338f1cd4b588d4244e49860f35bdda7c3a6
Cr-Commit-Position: refs/heads/master@{#296623}