DescriptionRevert of Listen to Off The Record profiles in ContentSettingsHandler. (patchset #3 id:60001 of https://codereview.chromium.org/676083003/)
Reason for revert:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29
is dying consistently in GuestModeOptionsBrowserTest.LoadOptionsByURL:
[16175:16175:1024/205028:FATAL:observer_list.h(159)] Check failed: false. Observers can only be added once!
#0 0x7fca41ce4b8e base::debug::StackTrace::StackTrace()
This looks like a very related CL.
Original issue's description:
> Listen to Off The Record profiles in ContentSettingsHandler.
>
> ContentSettingsHandler is now made aware of Off The Record profiles
> and will observe them as well, correcting bugs where changes from the
> settings webUI would function incorrectly.
>
> This is a rework of a previously landed fix [fix] which was reverted due to
> a crash bug [crash] when OTR profiles already existed before settings
> were opened.
>
> [fix] https://codereview.chromium.org/585953003
> [crash] https://code.google.com/p/chromium/issues/detail?id=417597
>
> BUG=425079, 418931
>
> Committed: https://crrev.com/c9ba380c606442a025a38eb67f4d35c65b1a293c
> Cr-Commit-Position: refs/heads/master@{#301273}
TBR=thestig@chromium.org,scheib@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=425079, 418931
Committed: https://crrev.com/044230f107b10d7545e761565caced0c1a55b521
Cr-Commit-Position: refs/heads/master@{#301292}
Patch Set 1 #
Created: 6 years, 1 month ago
(Patch set is too large to download)
Messages
Total messages: 6 (0 generated)
|