Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 652183006: Revert of Listen to Off The Record profiles in ContentSettingsHandler. (Closed)

Created:
6 years, 1 month ago by Avi (use Gerrit)
Modified:
6 years, 1 month ago
Reviewers:
Lei Zhang, scheib
CC:
chromium-reviews, dbeam+watch-options_chromium.org, Daniel Nishi
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Revert of Listen to Off The Record profiles in ContentSettingsHandler. (patchset #3 id:60001 of https://codereview.chromium.org/676083003/) Reason for revert: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29 is dying consistently in GuestModeOptionsBrowserTest.LoadOptionsByURL: [16175:16175:1024/205028:FATAL:observer_list.h(159)] Check failed: false. Observers can only be added once! #0 0x7fca41ce4b8e base::debug::StackTrace::StackTrace() This looks like a very related CL. Original issue's description: > Listen to Off The Record profiles in ContentSettingsHandler. > > ContentSettingsHandler is now made aware of Off The Record profiles > and will observe them as well, correcting bugs where changes from the > settings webUI would function incorrectly. > > This is a rework of a previously landed fix [fix] which was reverted due to > a crash bug [crash] when OTR profiles already existed before settings > were opened. > > [fix] https://codereview.chromium.org/585953003 > [crash] https://code.google.com/p/chromium/issues/detail?id=417597 > > BUG=425079, 418931 > > Committed: https://crrev.com/c9ba380c606442a025a38eb67f4d35c65b1a293c > Cr-Commit-Position: refs/heads/master@{#301273} TBR=thestig@chromium.org,scheib@chromium.org NOTREECHECKS=true NOTRY=true BUG=425079, 418931 Committed: https://crrev.com/044230f107b10d7545e761565caced0c1a55b521 Cr-Commit-Position: refs/heads/master@{#301292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M base/scoped_observer.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 2 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Avi (use Gerrit)
Created Revert of Listen to Off The Record profiles in ContentSettingsHandler.
6 years, 1 month ago (2014-10-25 19:15:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652183006/1
6 years, 1 month ago (2014-10-25 19:16:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-25 19:16:55 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/044230f107b10d7545e761565caced0c1a55b521 Cr-Commit-Position: refs/heads/master@{#301292}
6 years, 1 month ago (2014-10-25 19:17:34 UTC) #4
Avi (use Gerrit)
On 2014/10/25 19:17:34, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
6 years, 1 month ago (2014-10-25 20:12:57 UTC) #5
scheib
6 years, 1 month ago (2014-10-25 20:16:14 UTC) #6
Message was sent while issue was closed.
Thank you avi for following through on this.

On Sat, Oct 25, 2014 at 1:12 PM, <avi@chromium.org> wrote:

> On 2014/10/25 19:17:34, I haz the power (commit-bot) wrote:
>
>> Patchset 1 (id:??) landed as
>> https://crrev.com/044230f107b10d7545e761565caced0c1a55b521
>> Cr-Commit-Position: refs/heads/master@{#301292}
>>
>
> The commit did indeed green the bot.
>
> https://codereview.chromium.org/652183006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698