Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.cc

Issue 652183006: Revert of Listen to Off The Record profiles in ContentSettingsHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/scoped_observer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/content_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc
index 0939b0533193b241acc46a97cb7b5e0dbd2d9992..48a875150ee7871f9209446f454748cd9b1909b0 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc
@@ -497,13 +497,7 @@
base::Unretained(this)));
flash_settings_manager_.reset(new PepperFlashSettingsManager(this, context));
-
- Profile* profile = Profile::FromWebUI(web_ui());
- observer_.Add(profile->GetHostContentSettingsMap());
- if (profile->HasOffTheRecordProfile()) {
- observer_.Add(
- profile->GetOffTheRecordProfile()->GetHostContentSettingsMap());
- }
+ observer_.Add(Profile::FromWebUI(web_ui())->GetHostContentSettingsMap());
}
void ContentSettingsHandler::InitializePage() {
@@ -535,22 +529,16 @@
const content::NotificationDetails& details) {
switch (type) {
case chrome::NOTIFICATION_PROFILE_DESTROYED: {
- Profile* profile = content::Source<Profile>(source).ptr();
- if (profile->IsOffTheRecord() &&
- observer_.IsObserving(profile->GetHostContentSettingsMap())) {
+ if (content::Source<Profile>(source).ptr()->IsOffTheRecord()) {
web_ui()->CallJavascriptFunction(
"ContentSettingsExceptionsArea.OTRProfileDestroyed");
- observer_.Remove(profile->GetHostContentSettingsMap());
}
break;
}
case chrome::NOTIFICATION_PROFILE_CREATED: {
- Profile* profile = content::Source<Profile>(source).ptr();
- if (profile->IsOffTheRecord()) {
+ if (content::Source<Profile>(source).ptr()->IsOffTheRecord())
UpdateAllOTRExceptionsViewsFromModel();
- observer_.Add(profile->GetHostContentSettingsMap());
- }
break;
}
« no previous file with comments | « base/scoped_observer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698