Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 652103003: replace newly added OVERRIDEs with override in chrome/browser/history/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace newly added OVERRIDEs with override in chrome/browser/history/ BUG=417463 Committed: https://crrev.com/525145e3ba9bd92130945e74211d5b24b94ef829 Cr-Commit-Position: refs/heads/master@{#300085}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/history/android/android_provider_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/chrome_history_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_history_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@sdefresne: can you please take a look at this tiny fixup to https://codereview.chromium.org/631253002 ?
6 years, 2 months ago (2014-10-16 18:52:53 UTC) #2
sdefresne
lgtm
6 years, 2 months ago (2014-10-17 08:53:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652103003/1
6 years, 2 months ago (2014-10-17 08:53:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 10:00:42 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 10:01:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/525145e3ba9bd92130945e74211d5b24b94ef829
Cr-Commit-Position: refs/heads/master@{#300085}

Powered by Google App Engine
This is Rietveld 408576698