Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 652103003: replace newly added OVERRIDEs with override in chrome/browser/history/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/history/chrome_history_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/history/android/android_provider_backend.h" 5 #include "chrome/browser/history/android/android_provider_backend.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 virtual void NotifyProfileError(sql::InitStatus init_status) override {} 72 virtual void NotifyProfileError(sql::InitStatus init_status) override {}
73 virtual void SetInMemoryBackend( 73 virtual void SetInMemoryBackend(
74 scoped_ptr<InMemoryHistoryBackend> backend) override {} 74 scoped_ptr<InMemoryHistoryBackend> backend) override {}
75 virtual void NotifyAddVisit(const history::BriefVisitInfo& info) override {} 75 virtual void NotifyAddVisit(const history::BriefVisitInfo& info) override {}
76 virtual void NotifyFaviconChanged(const std::set<GURL>& url) override { 76 virtual void NotifyFaviconChanged(const std::set<GURL>& url) override {
77 favicon_changed_.reset(new std::set<GURL>(url.begin(), url.end())); 77 favicon_changed_.reset(new std::set<GURL>(url.begin(), url.end()));
78 } 78 }
79 virtual void NotifyURLVisited(ui::PageTransition, 79 virtual void NotifyURLVisited(ui::PageTransition,
80 const history::URLRow& row, 80 const history::URLRow& row,
81 const history::RedirectList& redirects, 81 const history::RedirectList& redirects,
82 base::Time visit_time) OVERRIDE {} 82 base::Time visit_time) override {}
83 virtual void BroadcastNotifications( 83 virtual void BroadcastNotifications(
84 int type, 84 int type,
85 scoped_ptr<HistoryDetails> details) override { 85 scoped_ptr<HistoryDetails> details) override {
86 switch (type) { 86 switch (type) {
87 case chrome::NOTIFICATION_HISTORY_URLS_DELETED: 87 case chrome::NOTIFICATION_HISTORY_URLS_DELETED:
88 deleted_details_.reset( 88 deleted_details_.reset(
89 static_cast<URLsDeletedDetails*>(details.release())); 89 static_cast<URLsDeletedDetails*>(details.release()));
90 break; 90 break;
91 case chrome::NOTIFICATION_HISTORY_URLS_MODIFIED: 91 case chrome::NOTIFICATION_HISTORY_URLS_MODIFIED:
92 modified_details_.reset( 92 modified_details_.reset(
(...skipping 2014 matching lines...) Expand 10 before | Expand all | Expand 10 after
2107 update_args, &update_count)); 2107 update_args, &update_count));
2108 // Verify notifications. 2108 // Verify notifications.
2109 EXPECT_FALSE(delegate_.deleted_details()); 2109 EXPECT_FALSE(delegate_.deleted_details());
2110 ASSERT_TRUE(delegate_.modified_details()); 2110 ASSERT_TRUE(delegate_.modified_details());
2111 ASSERT_EQ(1u, delegate_.modified_details()->changed_urls.size()); 2111 ASSERT_EQ(1u, delegate_.modified_details()->changed_urls.size());
2112 // No favicon will be updated as thumbnail database is missing. 2112 // No favicon will be updated as thumbnail database is missing.
2113 EXPECT_FALSE(delegate_.favicon_changed()); 2113 EXPECT_FALSE(delegate_.favicon_changed());
2114 } 2114 }
2115 2115
2116 } // namespace history 2116 } // namespace history
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/history/chrome_history_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698