Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 651923002: [Android] Push gtest deps in gtest/setup.py. (Closed)

Created:
6 years, 2 months ago by jbudorick
Modified:
6 years, 2 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, glider+watch_chromium.org, yfriedman+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Push gtest deps in gtest/setup.py. This patch is an alternative approach to only attempting to push gtest deps once. (The first attempt to do this, landed in https://codereview.chromium.org/560133002, caused issues and had to be reverted.) BUG=400440 Committed: https://crrev.com/8db64ed2849bd1a919c9004c9456b29467b50520 Cr-Commit-Position: refs/heads/master@{#299314}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -37 lines) Patch
M build/android/pylib/gtest/setup.py View 1 3 chunks +18 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/test_package_apk.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/gtest/test_runner.py View 2 chunks +0 lines, -17 lines 0 comments Download
M build/android/pylib/instrumentation/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/valgrind_tools.py View 8 chunks +42 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
6 years, 2 months ago (2014-10-13 15:05:10 UTC) #2
klundberg
lgtm
6 years, 2 months ago (2014-10-13 16:08:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651923002/80001
6 years, 2 months ago (2014-10-13 16:11:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:80001)
6 years, 2 months ago (2014-10-13 17:29:53 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 17:30:41 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8db64ed2849bd1a919c9004c9456b29467b50520
Cr-Commit-Position: refs/heads/master@{#299314}

Powered by Google App Engine
This is Rietveld 408576698