Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Issue 560133002: [Android] Don't push deps when listing gtests. (Closed)

Created:
6 years, 3 months ago by jbudorick
Modified:
6 years, 3 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Don't push deps when listing gtests. PushDataDeps takes a long time even when all files are on the device because calculating the digests of all the files takes _much_ longer on a device than it does on a host. Skipping the push step during test listing -- where the data deps are unnecessary -- means that we don't try to push files twice in each gtest run, so we skip all of the device-side MD5 calculations that would happen in the second run. BUG=400440 Committed: https://crrev.com/5c10479a0c3572cd41062b453c3e85527b5cfbad Cr-Commit-Position: refs/heads/master@{#294667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/android/pylib/gtest/setup.py View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbudorick
6 years, 3 months ago (2014-09-11 01:15:15 UTC) #2
klundberg
lgtm
6 years, 3 months ago (2014-09-11 03:47:43 UTC) #3
cjhopman
lgtm
6 years, 3 months ago (2014-09-12 20:26:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/560133002/1
6 years, 3 months ago (2014-09-12 20:34:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as f305d0191cc020934c6f13db54e46ffb8d24e647
6 years, 3 months ago (2014-09-12 21:41:59 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5c10479a0c3572cd41062b453c3e85527b5cfbad Cr-Commit-Position: refs/heads/master@{#294667}
6 years, 3 months ago (2014-09-12 21:46:30 UTC) #8
jbudorick
6 years, 2 months ago (2014-10-02 23:31:25 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/627553002/ by jbudorick@chromium.org.

The reason for reverting is: While we do want to only attempt to push once, this
isn't the right way to do it. We should push _before_ attempting to list the
tests, then be done with it.

Also, this breaks https://codereview.chromium.org/537063002/.

Powered by Google App Engine
This is Rietveld 408576698