Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 651603004: Fix fetch-canvas-tainting.html to not mix up origins and transferables. (Closed)

Created:
6 years, 2 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 2 months ago
CC:
blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Project:
blink
Visibility:
Public.

Description

Fix fetch-canvas-tainting.html to not mix up origins and transferables. The signature of Window's postMessage is message, target origin, transferables; not message, transferables, target origin. https://html.spec.whatwg.org/multipage/comms.html#dom-window-postmessage BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M LayoutTests/http/tests/serviceworker/fetch-canvas-tainting.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-10-22 06:59:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/651603004/1
6 years, 2 months ago (2014-10-23 02:04:17 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 03:08:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184230

Powered by Google App Engine
This is Rietveld 408576698