components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc - Issue 651443005: Use no-op statistics collecting object for WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

Issue 651443005: Use no-op statistics collecting object for WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor2

Patch Set: Selim and Ben's comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics.h » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_statistics.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

index 3e02cc844523f3145894e1706cc02b21e5da0bfa..ee9f9a1368f0e4a89a52986d26df13f25757e718 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc

@@ -150,7 +150,7 @@ void DataReductionProxySettingsTestBase::ResetSettings(bool allowed,

settings_.reset(settings);

configurator_.reset(new TestDataReductionProxyConfig());

settings_->configurator_ = configurator_.get();

- settings_->SetDataReductionProxyStatisticsPrefs(statistics_prefs_.get());

+ settings_->SetDataReductionProxyStatistics(statistics_prefs_.get());

}

// Explicitly generate required instantiations.