Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1727)

Unified Diff: android_webview/browser/net/aw_url_request_context_getter.cc

Issue 651443005: Use no-op statistics collecting object for WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor2
Patch Set: Selim and Ben's comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/net/aw_url_request_context_getter.cc
diff --git a/android_webview/browser/net/aw_url_request_context_getter.cc b/android_webview/browser/net/aw_url_request_context_getter.cc
index e37f59ec7e5ed4b0ed43e351b48dfbebae1a9fe3..6dab2e6e389bbd405ca6a879d0fb43158aedb9cc 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.cc
+++ b/android_webview/browser/net/aw_url_request_context_getter.cc
@@ -44,10 +44,10 @@
using content::BrowserThread;
using data_reduction_proxy::DataReductionProxySettings;
+using data_reduction_proxy::DataReductionProxyStatisticsPrefs;
sgurun-gerrit only 2014/10/17 20:29:38 stale?
hush (inactive) 2014/10/17 21:19:47 Done.
namespace android_webview {
-
namespace {
void ApplyCmdlineOverridesToURLRequestContextBuilder(
@@ -172,7 +172,8 @@ scoped_ptr<net::URLRequestJobFactory> CreateJobFactory(
} // namespace
AwURLRequestContextGetter::AwURLRequestContextGetter(
- const base::FilePath& partition_path, net::CookieStore* cookie_store,
+ const base::FilePath& partition_path,
+ net::CookieStore* cookie_store,
scoped_ptr<data_reduction_proxy::DataReductionProxyConfigService>
config_service)
: partition_path_(partition_path),
@@ -237,9 +238,9 @@ void AwURLRequestContextGetter::InitializeURLRequestContext() {
data_reduction_proxy_settings->params(),
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO)));
- // Compression statistics are not gathered for WebView, so
- // DataReductionProxyStatisticsPrefs is not instantiated and passed to the
- // network delegate.
+ // Compression statistics are not gathered for WebView. We don't set it here,
+ // which means a default dummy DataReductionProxyStatistics will be used.
sgurun-gerrit only 2014/10/17 20:29:38 I don't think we will need this comment anymore, s
hush (inactive) 2014/10/18 02:09:15 Done.
+
aw_network_delegate->set_data_reduction_proxy_params(
data_reduction_proxy_settings->params());
aw_network_delegate->set_data_reduction_proxy_auth_request_handler(

Powered by Google App Engine
This is Rietveld 408576698