Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/file_manager_dialog_base.js

Issue 651403002: Fix trivial type-check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and correct a comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/file_manager_dialog_base.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/file_manager_dialog_base.js b/ui/file_manager/file_manager/foreground/js/ui/file_manager_dialog_base.js
index 94b40eb5e4048cdd18bd93e4d8a36639415ed4c9..5d56a74dccd811479ed3f718a4ac69f9f503ec26 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/file_manager_dialog_base.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/file_manager_dialog_base.js
@@ -46,8 +46,8 @@ FileManagerDialogBase.shown = false;
/**
* @param {string} title Title.
* @param {string} message Message.
- * @param {function()} onOk Called when the OK button is pressed.
- * @param {function()} onCancel Called when the cancel button is pressed.
+ * @param {?function()} onOk Called when the OK button is pressed.
+ * @param {?function()} onCancel Called when the cancel button is pressed.
* @return {boolean} True if the dialog can show successfully. False if the
* dialog failed to show due to an existing dialog.
*/
@@ -59,8 +59,8 @@ FileManagerDialogBase.prototype.showOkCancelDialog = function(
/**
* @param {string} title Title.
* @param {string} message Message.
- * @param {function()} onOk Called when the OK button is pressed.
- * @param {function()} onCancel Called when the cancel button is pressed.
+ * @param {?function()} onOk Called when the OK button is pressed.
+ * @param {?function()} onCancel Called when the cancel button is pressed.
* @return {boolean} True if the dialog can show successfully. False if the
* dialog failed to show due to an existing dialog.
* @private
@@ -84,7 +84,7 @@ FileManagerDialogBase.prototype.showImpl_ = function(
* dialog failed to show due to an existing dialog.
*/
FileManagerDialogBase.prototype.showBlankDialog = function() {
- return this.showImpl_('', '', null, null, null);
+ return this.showImpl_('', '', null, null);
};
/**
@@ -93,7 +93,7 @@ FileManagerDialogBase.prototype.showBlankDialog = function() {
* dialog failed to show due to an existing dialog.
*/
FileManagerDialogBase.prototype.showTitleOnlyDialog = function(title) {
- return this.showImpl_(title, '', null, null, null);
+ return this.showImpl_(title, '', null, null);
};
/**
@@ -104,11 +104,11 @@ FileManagerDialogBase.prototype.showTitleOnlyDialog = function(title) {
*/
FileManagerDialogBase.prototype.showTitleAndTextDialog = function(title, text) {
this.buttons.style.display = 'none';
- return this.showImpl_(title, text, null, null, null);
+ return this.showImpl_(title, text, null, null);
};
/**
- * @param {function()=} opt_onHide Called when the dialog is hidden.
+ * @param {Function=} opt_onHide Called when the dialog is hidden.
*/
FileManagerDialogBase.prototype.hide = function(opt_onHide) {
cr.ui.dialogs.BaseDialog.prototype.hide.call(

Powered by Google App Engine
This is Rietveld 408576698