Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/file_grid.js

Issue 651403002: Fix trivial type-check errors in file_manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and correct a comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/file_grid.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/file_grid.js b/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
index d007f5fa1ea1dd91c918bbd2e0b5fd289bcf0f50..d1398d93d5e58208294dd7501fd42402d0cb282f 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/file_grid.js
@@ -44,12 +44,12 @@ FileGrid.decorate = function(self, metadataCache, volumeManager) {
self.volumeManager_ = volumeManager;
self.scrollBar_ = new MainPanelScrollBar();
- self.scrollBar_.initialize(self.parentNode, self);
+ self.scrollBar_.initialize(self.parentElement, self);
self.setBottomMarginForPanel(0);
self.itemConstructor = function(entry) {
var item = self.ownerDocument.createElement('LI');
- FileGrid.Item.decorate(item, entry, self);
+ FileGrid.Item.decorate(item, entry, /** @type {FileGrid} */ (self));
return item;
};
@@ -102,7 +102,7 @@ FileGrid.prototype.relayoutImmediately_ = function() {
/**
* Decorates thumbnail.
- * @param {HTMLElement} li List item.
+ * @param {cr.ui.ListItem} li List item.
* @param {Entry} entry Entry to render a thumbnail for.
* @param {MetadataCache} metadataCache To retrieve metadata.
* @param {VolumeManagerWrapper} volumeManager Volume manager instance.
@@ -136,14 +136,14 @@ FileGrid.decorateThumbnail = function(li, entry, metadataCache, volumeManager) {
/**
* Decorates the box containing a centered thumbnail image.
*
- * @param {HTMLDivElement} box Box to decorate.
+ * @param {Element} box Box to decorate.
* @param {Entry} entry Entry which thumbnail is generating for.
* @param {MetadataCache} metadataCache To retrieve metadata.
* @param {VolumeManagerWrapper} volumeManager Volume manager instance.
* @param {ThumbnailLoader.FillMode} fillMode Fill mode.
* @param {FileGrid.ThumbnailQuality} quality Thumbnail quality.
- * @param {function(HTMLElement)=} opt_imageLoadCallback Callback called when
- * the image has been loaded before inserting it into the DOM.
+ * @param {function(HTMLImageElement)=} opt_imageLoadCallback Callback called
+ * when the image has been loaded before inserting it into the DOM.
*/
FileGrid.decorateThumbnailBox = function(
box, entry, metadataCache, volumeManager, fillMode, quality,
@@ -199,6 +199,7 @@ FileGrid.decorateThumbnailBox = function(
/**
* Item for the Grid View.
* @constructor
+ * @extends {cr.ui.ListItem}
*/
FileGrid.Item = function() {
throw new Error();

Powered by Google App Engine
This is Rietveld 408576698