Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 651243005: Add support for attaching observatory to the server (Closed)

Created:
6 years, 2 months ago by Brian Wilkerson
Modified:
6 years, 2 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add support for attaching observatory to the server. R=paulberry@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41267

Patch Set 1 #

Total comments: 2

Messages

Total messages: 6 (1 generated)
Brian Wilkerson
6 years, 2 months ago (2014-10-23 17:55:53 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-23 17:56:30 UTC) #3
Paul Berry
lgtm https://codereview.chromium.org/651243005/diff/1/pkg/analysis_server/test/integration/integration_tests.dart File pkg/analysis_server/test/integration/integration_tests.dart (right): https://codereview.chromium.org/651243005/diff/1/pkg/analysis_server/test/integration/integration_tests.dart#newcode702 pkg/analysis_server/test/integration/integration_tests.dart:702: // arguments.add('--enable-vm-service'); Were these commented-out lines left in ...
6 years, 2 months ago (2014-10-23 18:02:11 UTC) #4
Brian Wilkerson
https://codereview.chromium.org/651243005/diff/1/pkg/analysis_server/test/integration/integration_tests.dart File pkg/analysis_server/test/integration/integration_tests.dart (right): https://codereview.chromium.org/651243005/diff/1/pkg/analysis_server/test/integration/integration_tests.dart#newcode702 pkg/analysis_server/test/integration/integration_tests.dart:702: // arguments.add('--enable-vm-service'); > Were these commented-out lines left in ...
6 years, 2 months ago (2014-10-23 18:56:19 UTC) #5
Brian Wilkerson
6 years, 2 months ago (2014-10-23 19:18:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698