Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: pkg/analysis_server/test/integration/integration_tests.dart

Issue 651243005: Add support for attaching observatory to the server (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/integration_tests.dart b/pkg/analysis_server/test/integration/integration_tests.dart
index 372293d5fb5df43d3e4e5e087a66898578f317ef..fa0c66b65062d4124ff7c5e53395db75310288c1 100644
--- a/pkg/analysis_server/test/integration/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/integration_tests.dart
@@ -150,7 +150,7 @@ abstract class AbstractAnalysisServerIntegrationTest extends
expect(serverConnected.isCompleted, isFalse);
serverConnected.complete();
});
- return server.start().then((_) {
+ return server.start(null).then((_) {
server.listenToOutput(dispatchNotification);
server.exitCode.then((_) {
skipShutdown = true;
@@ -679,10 +679,13 @@ class Server {
}
/**
- * Start the server. If [debugServer] is true, the server will be started
- * with "--debug", allowing a debugger to be attached.
+ * Start the server. If [debugServer] is `true`, the server will be started
+ * with "--debug", allowing a debugger to be attached. If [profileServer] is
+ * `true`, the server will be started with "--observe" and
+ * "--pause-isolates-on-exit", allowing the observatory to be used.
*/
- Future start({bool debugServer: false}) {
+ Future start(NotificationProcessor notificationProcessor, {bool debugServer:
+ false, bool profileServer: true}) {
if (_process != null) {
throw new Exception('Process already started');
}
@@ -695,6 +698,12 @@ class Server {
if (debugServer) {
arguments.add('--debug');
}
+ if (profileServer) {
+// arguments.add('--enable-vm-service');
Paul Berry 2014/10/23 18:02:11 Were these commented-out lines left in on purpose
Brian Wilkerson 2014/10/23 18:56:19 Sort of on purpose in that when I first uploaded I
+ arguments.add('--observe');
+// arguments.add('--profile');
+ arguments.add('--pause-isolates-on-exit');
+ }
if (Platform.packageRoot.isNotEmpty) {
arguments.add('--package-root=${Platform.packageRoot}');
}

Powered by Google App Engine
This is Rietveld 408576698