Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2044)

Unified Diff: chrome/browser/history/chrome_history_client.h

Issue 651193002: Remove NOTIFICATION_HISTORY_URL_VISITED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@373326.2
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/chrome_history_client.h
diff --git a/chrome/browser/history/chrome_history_client.h b/chrome/browser/history/chrome_history_client.h
index 1fd20a3316ba94f742afc40a1dad652a1c9b61ad..13ef0815cbd7f800fb3b18f2f753693550180d49 100644
--- a/chrome/browser/history/chrome_history_client.h
+++ b/chrome/browser/history/chrome_history_client.h
@@ -31,7 +31,7 @@ class ChromeHistoryClient : public history::HistoryClient,
// TODO(sdefresne): once NOTIFICATION_HISTORY_URL* notifications are no
// longer used, remove this reference to the HistoryService from the
- // ChromeHistoryClient, http://crbug.com/42178
+ // ChromeHistoryClient, http://crbug.com/373326
void SetHistoryService(HistoryService* history_service);
// history::HistoryClient:
@@ -45,13 +45,6 @@ class ChromeHistoryClient : public history::HistoryClient,
// KeyedService:
virtual void Shutdown() override;
- // HistoryServiceObserver:
- virtual void OnURLVisited(HistoryService* history_service,
- ui::PageTransition transition,
- const history::URLRow& row,
- const history::RedirectList& redirects,
- base::Time visit_time) OVERRIDE;
-
// TopSitesObserver:
virtual void TopSitesLoaded(history::TopSites* top_sites) override;
virtual void TopSitesChanged(history::TopSites* top_sites) override;

Powered by Google App Engine
This is Rietveld 408576698