Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5327)

Unified Diff: chrome/browser/history/chrome_history_client.cc

Issue 651193002: Remove NOTIFICATION_HISTORY_URL_VISITED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@373326.2
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/chrome_history_client.cc
diff --git a/chrome/browser/history/chrome_history_client.cc b/chrome/browser/history/chrome_history_client.cc
index 2732524cd3bf45d36d2dd1a59ff382e79937b476..c492292e3ed4e148f01963ca5f6d52744c6404a2 100644
--- a/chrome/browser/history/chrome_history_client.cc
+++ b/chrome/browser/history/chrome_history_client.cc
@@ -91,27 +91,6 @@ void ChromeHistoryClient::Shutdown() {
history_service_->RemoveObserver(this);
}
-// TODO(sdefresne): port client listening for NOTIFICATION_HISTORY_URL_VISITED
-// to use the HistoryService::Observer pattern instead and remove this method
-// when this is complete, http://crbug.com/42178
-void ChromeHistoryClient::OnURLVisited(HistoryService* history_service,
- ui::PageTransition transition,
- const history::URLRow& row,
- const history::RedirectList& redirects,
- base::Time visit_time) {
- DCHECK(history_service == history_service_);
- scoped_ptr<history::URLVisitedDetails> details(
- new history::URLVisitedDetails);
- details->transition = transition;
- details->row = row;
- details->redirects = redirects;
- details->visit_time = visit_time;
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_HISTORY_URL_VISITED,
- content::Source<Profile>(profile_),
- content::Details<history::HistoryDetails>(details.get()));
-}
-
void ChromeHistoryClient::TopSitesLoaded(history::TopSites* top_sites) {
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_TOP_SITES_LOADED,

Powered by Google App Engine
This is Rietveld 408576698