Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 650963002: [Password Generation] Manage passwords link should point to local password store (Closed)

Created:
6 years, 2 months ago by Garrett Casto
Modified:
6 years, 2 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Manage passwords link should point to local password store BUG=422688 Committed: https://crrev.com/aaa3dd8a396ccf0a47c34d757d1cff3e0379fcfd Cr-Commit-Position: refs/heads/master@{#299373}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Garrett Casto
6 years, 2 months ago (2014-10-13 19:50:25 UTC) #3
Evan Stade
lgtm
6 years, 2 months ago (2014-10-13 21:17:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650963002/70001
6 years, 2 months ago (2014-10-13 21:27:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:70001)
6 years, 2 months ago (2014-10-13 21:54:45 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 21:55:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaa3dd8a396ccf0a47c34d757d1cff3e0379fcfd
Cr-Commit-Position: refs/heads/master@{#299373}

Powered by Google App Engine
This is Rietveld 408576698