Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3112)

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

Issue 650963002: [Password Generation] Manage passwords link should point to local password store (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
index ce6ff75abb6bbe7623ea711c2b954fe5c13bbe76..a2a2c7f924588f0fe188d36aa85dfb3200d71e0f 100644
--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
@@ -14,8 +14,8 @@
#include "chrome/browser/ui/autofill/password_generation_popup_observer.h"
#include "chrome/browser/ui/autofill/password_generation_popup_view.h"
#include "chrome/browser/ui/autofill/popup_constants.h"
-#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/chrome_pages.h"
#include "chrome/common/url_constants.h"
#include "chrome/grit/chromium_strings.h"
#include "chrome/grit/generated_resources.h"
@@ -214,12 +214,9 @@ void PasswordGenerationPopupControllerImpl::ViewDestroyed() {
}
void PasswordGenerationPopupControllerImpl::OnSavedPasswordsLinkClicked() {
- Browser* browser =
- chrome::FindBrowserWithWebContents(controller_common_.web_contents());
- content::OpenURLParams params(
- GURL(chrome::kPasswordManagerAccountDashboardURL), content::Referrer(),
- NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK, false);
- browser->OpenURL(params);
+ chrome::ShowSettingsSubPage(
+ chrome::FindBrowserWithWebContents(controller_common_.web_contents()),
+ chrome::kPasswordManagerSubPage);
}
void PasswordGenerationPopupControllerImpl::SetSelectionAtPoint(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698