GN: make relocation packing work

GN: make relocation packing work

This adds pretty straightforward conversion of the relocation package
gyp targets.

The android_apk template is updated to use pack_arm_relocations.py
instead of copy_ex.py for copying native libraries into the directory
used to build the apk.  This script will copy the files when relocation
packing is disabled and otherwise will do the relocation packing (just
like it does in gyp).

BUG=359249
Committed: https://crrev.com/284a11b8e10b24d85247dc447dfb3ae812b75f91
Cr-Commit-Position: refs/heads/master@{#300969}

[cjhopman, 2014-10-16 21:46:15]

cjhopman@chromium.org changed reviewers:
+ simonb@chromium.org

[cjhopman, 2014-10-16 21:46:16]

simonb, ptal

[simonb (inactive), 2014-10-17 12:30:20]

https://codereview.chromium.org/650933003/diff/100001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/650933003/diff/100001/build/config/android/ru...
build/config/android/rules.gni:1007: has_relocations_with_addends = 0
Should be 0 for arm, 1 for arm64.

https://codereview.chromium.org/650933003/diff/100001/build/config/android/ru...
build/config/android/rules.gni:1011: enable_packing = false
Always false?  (How is packing turned on?  It is now on in clank.gyp.)

https://codereview.chromium.org/650933003/diff/100001/build/config/android/ru...
build/config/android/rules.gni:1031: rebased_gdbserver = rebase_path([
android_gdbserver ], root_build_dir)
This seems unconnected with relocation packing work.  Part of a different
change?

https://codereview.chromium.org/650933003/diff/100001/tools/relocation_packer...
File tools/relocation_packer/BUILD.gn (right):

https://codereview.chromium.org/650933003/diff/100001/tools/relocation_packer...
tools/relocation_packer/BUILD.gn:10: }
You could 'else assert...' here, I think, if you wish.  If target_arch is not
one of the two valid values then compilation will fail hard.  The only reason
gyp didn't do this is because it lacks assert.

[cjhopman, 2014-10-17 20:55:19]

https://codereview.chromium.org/650933003/diff/100001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/650933003/diff/100001/build/config/android/ru...
build/config/android/rules.gni:1007: has_relocations_with_addends = 0
On 2014/10/17 12:30:20, simonb wrote:
> Should be 0 for arm, 1 for arm64.

Done. This is in //tools/relocation_packer/config.gni

https://codereview.chromium.org/650933003/diff/100001/build/config/android/ru...
build/config/android/rules.gni:1011: enable_packing = false
On 2014/10/17 12:30:20, simonb wrote:
> Always false?  (How is packing turned on?  It is now on in clank.gyp.)

Done.

https://codereview.chromium.org/650933003/diff/100001/build/config/android/ru...
build/config/android/rules.gni:1031: rebased_gdbserver = rebase_path([
android_gdbserver ], root_build_dir)
On 2014/10/17 12:30:20, simonb wrote:
> This seems unconnected with relocation packing work.  Part of a different
> change?

We want gdbserver in the native libraries directory for debug builds.
pack_arm_relocations.py sets up that directory for us, and so we tell it to
include gdbserver here. It's in the skip_packing_list above so it will always
just copy it.

https://codereview.chromium.org/650933003/diff/100001/tools/relocation_packer...
File tools/relocation_packer/BUILD.gn (right):

https://codereview.chromium.org/650933003/diff/100001/tools/relocation_packer...
tools/relocation_packer/BUILD.gn:10: }
On 2014/10/17 12:30:20, simonb wrote:
> You could 'else assert...' here, I think, if you wish.  If target_arch is not
> one of the two valid values then compilation will fail hard.  The only reason
> gyp didn't do this is because it lacks assert.
> 

Done.

[simonb (inactive), 2014-10-20 13:06:10]

lgtm

https://codereview.chromium.org/650933003/diff/120001/build/config/android/ru...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/650933003/diff/120001/build/config/android/ru...
build/config/android/rules.gni:844: assert(_enable_relocation_packing || true)
Does this do anything?  (Also for _use_chromium_linker above.)

https://codereview.chromium.org/650933003/diff/120001/tools/relocation_packer...
File tools/relocation_packer/BUILD.gn (right):

https://codereview.chromium.org/650933003/diff/120001/tools/relocation_packer...
tools/relocation_packer/BUILD.gn:13: }
Would it make any sense to move target_define settings to config.gni?  Or not? 
(Don't mind either way.)

[cjhopman, 2014-10-23 20:53:34]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-10-23 20:55:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650933003/120001

[commit-bot: I haz the power, 2014-10-23 21:01:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-23 21:01:12]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/72755)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[cjhopman, 2014-10-23 21:23:50]

The CQ bit was checked by cjhopman@chromium.org

[commit-bot: I haz the power, 2014-10-23 21:24:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650933003/140001

[commit-bot: I haz the power, 2014-10-23 23:03:49]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2014-10-23 23:04:19]

Patchset 5 (id:??) landed as
https://crrev.com/284a11b8e10b24d85247dc447dfb3ae812b75f91
Cr-Commit-Position: refs/heads/master@{#300969}