GN: make relocation packing work

build/config/android/rules.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/android/internal_rules.gni")
 import("//tools/grit/grit_rule.gni")
+import("//tools/relocation_packer/config.gni")
 
 assert(is_android)
 
-
 # Declare a jni target
 #
 # This target generates the native jni bindings for a set of .java files.
 #
 # See base/android/jni_generator/jni_generator.py for more info about the
 # format of generating JNI bindings.
 #
 # Variables
 #   sources: list of .java files to generate jni for
 #   jni_package: subdirectory path for generated bindings
@@ skipping 808 matching lines @@
   _dist_jar_path = _dist_jar_path_list[0]
 
   _native_libs = []
 
   _use_chromium_linker = false
   if (defined(invoker.use_chromium_linker)) {
     _use_chromium_linker = invoker.use_chromium_linker
   }
   assert(_use_chromium_linker || true)
 
+  _enable_relocation_packing = false
+  if (defined(invoker.enable_relocation_packing)) {
+    _enable_relocation_packing = invoker.enable_relocation_packing
+  }
+  assert(_enable_relocation_packing || true)

[simonb (inactive), 2014/10/20 13:06:09]

Does this do anything?  (Also for _use_chromium_linker above.)

+
+  if (_enable_relocation_packing) {
+    assert(_use_chromium_linker, "Relocation packing requires use of the" +
+        "Chromium linker.")
+  }
+
   _load_library_from_apk = false
   if (defined(invoker.load_library_from_apk)) {
     _load_library_from_apk = invoker.load_library_from_apk
   }
 
   _keystore_path = android_default_keystore_path
   _keystore_name = android_default_keystore_name
   _keystore_password = android_default_keystore_password
 
   if (defined(invoker.keystore_path)) {
     _keystore_path = invoker.keystore_path
     _keystore_name = invoker.keystore_name
     _keystore_password = invoker.keystore_password
   }
 
   _srcjar_deps = []
   if (defined(invoker.srcjar_deps)) {
     _srcjar_deps += invoker.srcjar_deps
   }
 
   if (defined(invoker.native_libs)) {
     # TODO(GYP) add "|| profiling_full_stack_frames
     # Only enable the chromium linker on regular builds, since the
     # component build crashes on Android 4.4. See b/11379966
     if (is_component_build || cpu_arch == "arm64" || cpu_arch == "x64") {
       _use_chromium_linker = false
     }
 
+    if (!_use_chromium_linker || !relocation_packing_supported) {
+      _enable_relocation_packing = false
+    }
+
     _native_libs = invoker.native_libs
     _native_libs_dir = base_path + "/libs"
 
     if (_use_chromium_linker) {
       _native_libs += [
         "$root_build_dir/lib.stripped/libchromium_android_linker.so"
       ]
     }
   }
 
@@ skipping 101 matching lines @@
   dex("${_template_name}__final_dex") {
     deps = [ ":${_template_name}__java" ]
     sources = [ jar_path ]
     inputs = [ build_config ]
     output = final_dex_path
     dex_arg_key = "${_rebased_build_config}:apk_dex:dependency_dex_files"
     args = [ "--inputs=@FileArg($dex_arg_key)" ]
   }
 
   if (_native_libs != []) {
-    copy_ex("${_template_name}__prepare_native") {
-      clear_dir = true
+    action("${_template_name}__prepare_native") {
+      script = "//build/android/gyp/pack_arm_relocations.py"
+      packed_libraries_dir = "$_native_libs_dir/$android_app_abi"
+      depfile = "$target_gen_dir/$target_name.d"
+      outputs = [
+        depfile
+      ]
       inputs = [
         build_config
       ]
-      dest = "$_native_libs_dir/$android_app_abi"
+      deps = []
+      skip_packing_list = [
+        "gdbserver",
+        "libchromium_android_linker.so",
+      ]
+
+      enable_packing_arg = 0
+      if (_enable_relocation_packing) {
+        enable_packing_arg = 1
+        deps += [
+          relocation_packer_target
+        ]
+      }
+
       args = [
-        "--files=@FileArg(${_rebased_build_config}:native:libraries)",
+        "--depfile", rebase_path(depfile, root_build_dir),
+        "--enable-packing=$enable_packing_arg",
+        "--has-relocations-with-addends=$relocations_have_addends",
+        "--exclude-packing-list=$skip_packing_list",
+        "--android-pack-relocations", rebase_path(relocation_packer_exe, root_build_dir),
+        "--android-objcopy", rebase_path(android_objcopy, root_build_dir),
+        "--stripped-libraries-dir", rebase_path(root_build_dir, root_build_dir),
+        "--packed-libraries-dir", rebase_path(packed_libraries_dir, root_build_dir),
+        "--libraries=@FileArg(${_rebased_build_config}:native:libraries)",
+        "--clear-dir"
       ]
+
       if (is_debug) {
-        rebased_gdbserver = rebase_path(android_gdbserver, root_build_dir)
+        rebased_gdbserver = rebase_path([ android_gdbserver ], root_build_dir)
+        inputs += [ android_gdbserver ]
         args += [
-          "--files=[\"$rebased_gdbserver\"]"
+          "--libraries=$rebased_gdbserver"
         ]
       }
     }
   }
 
   final_deps += [":${_template_name}__create"]
   create_apk("${_template_name}__create") {
     apk_path = _final_apk_path
     android_manifest = invoker.android_manifest
     resources_zip = all_resources_zip_path
@@ skipping 282 matching lines @@
 }
 
 # TODO(GYP): implement this.
 template("uiautomator_test") {
   if (defined(invoker.testonly)) { testonly = invoker.testonly }
   assert(target_name != "")
   assert(invoker.deps != [] || true)
   group(target_name) {
   }
 }