Non-SFI mode: build tracing_nacl library for nacl_helper_nonsfi.

Non-SFI mode: build tracing_nacl library for nacl_helper_nonsfi.

libtracing_nacl.a will be used by PPAPI library for nacl_helper_nonsfi.
This CL builds the library, but it is not used yet.
It is now for just making sure it is built properly.

BUG=358465
TEST=Ran trybot.

Committed: https://crrev.com/5beefae94a1761e4988d7aa6784e20c918ca1bd0
Cr-Commit-Position: refs/heads/master@{#301317}

[hidehiko, 2014-10-24 06:22:52]

hidehiko@chromium.org changed reviewers:
+ jbauman@chromium.org, mseaborn@chromium.org

[hidehiko, 2014-10-24 06:22:53]

jbauman@, could you review tracing_nacl.gyp as an OWNER?
mseaborn@, could you review this from the project point of view?

Thank you for your review in advance,
- hidehiko

https://codereview.chromium.org/650593003/diff/1/components/tracing_nacl.gyp
File components/tracing_nacl.gyp (right):

https://codereview.chromium.org/650593003/diff/1/components/tracing_nacl.gyp#...
components/tracing_nacl.gyp:20: '../ipc/ipc_nacl.gyp:ipc_nacl',
FYI: Fixed the dependency correctly.

[Mark Seaborn, 2014-10-24 18:02:50]

LGTM

https://codereview.chromium.org/650593003/diff/1/components/tracing_nacl.gyp
File components/tracing_nacl.gyp (right):

https://codereview.chromium.org/650593003/diff/1/components/tracing_nacl.gyp#...
components/tracing_nacl.gyp:19: '../base/base_nacl.gyp:base_nacl_nonsfi',
Technically you don't need to list any library dependencies here.

AFAIK, Gyp (and untrusted.gypi) don't do anything useful with them.

In the end, all transitive dependencies need to get listed in the target that
builds nacl_helper_nonsfi, so additionally listing that "library A depends on
library B" in the definition of library A doesn't actually help.  (Again,
AFAIK.)

https://codereview.chromium.org/650593003/diff/1/components/tracing_nacl.gyp#...
components/tracing_nacl.gyp:33: 'build_pnacl_newlib': 0,
I assume you've checked that no-one is using the pexe/plib build of this
library?

[jbauman, 2014-10-24 20:44:07]

lgtm

[hidehiko, 2014-10-27 05:10:13]

Thank you for review. Submitting.

https://codereview.chromium.org/650593003/diff/1/components/tracing_nacl.gyp
File components/tracing_nacl.gyp (right):

https://codereview.chromium.org/650593003/diff/1/components/tracing_nacl.gyp#...
components/tracing_nacl.gyp:19: '../base/base_nacl.gyp:base_nacl_nonsfi',
On 2014/10/24 18:02:49, Mark Seaborn wrote:
> Technically you don't need to list any library dependencies here.
> 
> AFAIK, Gyp (and untrusted.gypi) don't do anything useful with them.
> 
> In the end, all transitive dependencies need to get listed in the target that
> builds nacl_helper_nonsfi, so additionally listing that "library A depends on
> library B" in the definition of library A doesn't actually help.  (Again,
> AFAIK.)

Admittedly, compile order does not help the binary build, but it checks circular
dependencies. So (also, in order to keep the consistency with rules around
here), please let me keep this form as is.

If it is better to remove all deps among the untrusted.gypi related build rules
(except prep_toolchain, which actually needs to be listed, otherwise the build
may start before toolchain installation), please let me know.

https://codereview.chromium.org/650593003/diff/1/components/tracing_nacl.gyp#...
components/tracing_nacl.gyp:33: 'build_pnacl_newlib': 0,
On 2014/10/24 18:02:49, Mark Seaborn wrote:
> I assume you've checked that no-one is using the pexe/plib build of this
> library?

Yes, no one use it.

[hidehiko, 2014-10-27 05:10:18]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2014-10-27 05:10:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650593003/1

[commit-bot: I haz the power, 2014-10-27 05:52:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-27 05:53:34]

Patchset 1 (id:??) landed as
https://crrev.com/5beefae94a1761e4988d7aa6784e20c918ca1bd0
Cr-Commit-Position: refs/heads/master@{#301317}