Non-SFI mode: build tracing_nacl library for nacl_helper_nonsfi.

components/tracing_nacl.gyp

 # Copyright 2014 The Chromium Authors. All rights reserved.
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     '../build/common_untrusted.gypi',
   ],
   'conditions': [
     ['disable_nacl==0 and disable_nacl_untrusted==0', {
       'targets': [
         {
           'target_name': 'tracing_nacl',
           'type': 'none',
           'defines!': ['CONTENT_IMPLEMENTATION'],
           'dependencies': [
             '../base/base_nacl.gyp:base_nacl',
+            '../base/base_nacl.gyp:base_nacl_nonsfi',

[Mark Seaborn, 2014/10/24 18:02:49]

Technically you don't need to list any library dependencies here.

AFAIK, Gyp (and untrusted.gypi) don't do anything useful with them.

In the end, all transitive dependencies need to get listed in the target that
builds nacl_helper_nonsfi, so additionally listing that "library A depends on
library B" in the definition of library A doesn't actually help.  (Again,
AFAIK.)

[hidehiko, 2014/10/27 05:10:12]

Admittedly, compile order does not help the binary build, but it checks circular
dependencies. So (also, in order to keep the consistency with rules around
here), please let me keep this form as is.

If it is better to remove all deps among the untrusted.gypi related build rules
(except prep_toolchain, which actually needs to be listed, otherwise the build
may start before toolchain installation), please let me know.

+            '../ipc/ipc_nacl.gyp:ipc_nacl',

[hidehiko, 2014/10/24 06:22:53]

FYI: Fixed the dependency correctly.

+            '../ipc/ipc_nacl.gyp:ipc_nacl_nonsfi',
             '../native_client/tools.gyp:prep_toolchain',
-            '../ipc/ipc.gyp:ipc',
           ],
           'include_dirs': [
             '..',
           ],
           'variables': {
             'nacl_untrusted_build': 1,
             'nlib_target': 'libtracing_nacl.a',
             'build_glibc': 0,
             'build_newlib': 0,
             'build_irt': 1,
+            'build_pnacl_newlib': 0,

[Mark Seaborn, 2014/10/24 18:02:49]

I assume you've checked that no-one is using the pexe/plib build of this
library?

[hidehiko, 2014/10/27 05:10:12]

Yes, no one use it.

+            'build_nonsfi_helper': 1,
           },
           'sources': [
             'tracing/child_trace_message_filter.cc',
             'tracing/child_trace_message_filter.h',
             'tracing/tracing_messages.cc',
             'tracing/tracing_messages.h',
           ],
         },
       ],
     }],
   ],
 }