Make the accessible name of a browser action it's title

Make the accessible name of a browser action it's title

This was previously done, but was lost in some of the churn. Bring it back.
BUG=421782
Committed: https://crrev.com/554e70d004260affa8d26b0ed441f70ba59e85b9
Cr-Commit-Position: refs/heads/master@{#299304}

[Devlin, 2014-10-10 22:16:25]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org, pkasting@chromium.org

[Devlin, 2014-10-10 22:16:26]

https://codereview.chromium.org/650503002/diff/1/chrome/browser/ui/views/tool...
File chrome/browser/ui/views/toolbar/browser_action_view.cc (left):

https://codereview.chromium.org/650503002/diff/1/chrome/browser/ui/views/tool...
chrome/browser/ui/views/toolbar/browser_action_view.cc:118: state->name =
l10n_util::GetStringUTF16(
This was done as part of the conversion from having two views (BrowserActionView
and BrowserActionButton) to having just one, but it shouldn't have been.  Taking
this out lets state->name be set by Button::GetAccessibleState(), which sets it
to the accessible name set on line 153.

[Peter Kasting, 2014-10-10 22:17:31]

LGTM

[Finnur, 2014-10-13 12:58:39]

LGTM

[Devlin, 2014-10-13 15:57:17]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-10-13 15:58:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650503002/1

[commit-bot: I haz the power, 2014-10-13 16:17:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-13 16:18:26]

Patchset 1 (id:??) landed as
https://crrev.com/554e70d004260affa8d26b0ed441f70ba59e85b9
Cr-Commit-Position: refs/heads/master@{#299304}