Make the accessible name of a browser action it's title

chrome/browser/ui/views/toolbar/browser_action_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/toolbar/browser_action_view.h"
 
 #include <string>
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 97 matching lines @@
 void BrowserActionView::PaintChildren(gfx::Canvas* canvas,
                                       const views::CullSet& cull_set) {
   View::PaintChildren(canvas, cull_set);
   int tab_id = view_controller_->GetCurrentTabId();
   if (tab_id >= 0)
     extension_action()->PaintBadge(canvas, GetLocalBounds(), tab_id);
 }
 
 void BrowserActionView::GetAccessibleState(ui::AXViewState* state) {
   views::MenuButton::GetAccessibleState(state);
-  state->name = l10n_util::GetStringUTF16(

[Devlin, 2014/10/10 22:16:26]

This was done as part of the conversion from having two views (BrowserActionView
and BrowserActionButton) to having just one, but it shouldn't have been.  Taking
this out lets state->name be set by Button::GetAccessibleState(), which sets it
to the accessible name set on line 153.

-      IDS_ACCNAME_EXTENSIONS_BROWSER_ACTION);
   state->role = ui::AX_ROLE_BUTTON;
 }
 
 void BrowserActionView::ButtonPressed(views::Button* sender,
                                       const ui::Event& event) {
   view_controller_->ExecuteActionByUser();
 }
 
 void BrowserActionView::UpdateState() {
   int tab_id = view_controller_->GetCurrentTabId();
@@ skipping 207 matching lines @@
 }
 
 void BrowserActionView::CleanupPopup() {
   // We need to do these actions synchronously (instead of closing and then
   // performing the rest of the cleanup in OnWidgetDestroyed()) because
   // OnWidgetDestroyed() can be called asynchronously from Close(), and we need
   // to keep the delegate's popup owner up-to-date.
   delegate_->SetPopupOwner(NULL);
   pressed_lock_.reset();  // Unpress the menu button if it was pressed.
 }