Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 650473002: Strips some unnecessary deps in app_list_controller_delegate.cc (Closed)

Created:
6 years, 2 months ago by Jun Mukai
Modified:
6 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Strips some unnecessary deps in app_list_controller_delegate.cc - app_list_syncable_service is unnecessary at all - browser_navigator is not necessary, we've introduced OpenURL BUG=None R=xiyuan@chromium.org TEST=build succeeds Committed: https://crrev.com/8fab32f6225203a3fd56e0a723e65176126acbb5 Cr-Commit-Position: refs/heads/master@{#299378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M chrome/browser/ui/app_list/app_list_controller_delegate.cc View 3 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jun Mukai
6 years, 2 months ago (2014-10-13 21:05:01 UTC) #1
xiyuan
lgtm
6 years, 2 months ago (2014-10-13 21:07:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650473002/1
6 years, 2 months ago (2014-10-13 21:09:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 22:32:21 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 22:33:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fab32f6225203a3fd56e0a723e65176126acbb5
Cr-Commit-Position: refs/heads/master@{#299378}

Powered by Google App Engine
This is Rietveld 408576698