Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2989)

Unified Diff: chrome/browser/ui/app_list/app_list_controller_delegate.cc

Issue 650473002: Strips some unnecessary deps in app_list_controller_delegate.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/app_list_controller_delegate.cc
diff --git a/chrome/browser/ui/app_list/app_list_controller_delegate.cc b/chrome/browser/ui/app_list/app_list_controller_delegate.cc
index 7c30bced9c4e8731f17c768c05e70c7c8659b4cf..8aa801adb5a79bb9e2f35594fa6524cd790d453d 100644
--- a/chrome/browser/ui/app_list/app_list_controller_delegate.cc
+++ b/chrome/browser/ui/app_list/app_list_controller_delegate.cc
@@ -10,11 +10,8 @@
#include "chrome/browser/extensions/install_tracker_factory.h"
#include "chrome/browser/extensions/launch_util.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/app_list/app_list_syncable_service.h"
-#include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"
#include "chrome/browser/ui/app_list/extension_uninstaller.h"
#include "chrome/browser/ui/apps/app_info_dialog.h"
-#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/common/extensions/extension_constants.h"
#include "chrome/common/extensions/manifest_url_handler.h"
#include "extensions/browser/extension_prefs.h"
@@ -150,13 +147,12 @@ void AppListControllerDelegate::ShowAppInWebStore(
is_search_result ?
AppListControllerDelegate::LAUNCH_FROM_APP_LIST_SEARCH :
AppListControllerDelegate::LAUNCH_FROM_APP_LIST);
- chrome::NavigateParams params(
- profile,
- net::AppendQueryParameter(url,
- extension_urls::kWebstoreSourceField,
- source),
- ui::PAGE_TRANSITION_LINK);
- chrome::Navigate(&params);
+ OpenURL(profile,
+ net::AppendQueryParameter(url,
+ extension_urls::kWebstoreSourceField,
+ source),
+ ui::PAGE_TRANSITION_LINK,
+ CURRENT_TAB);
}
bool AppListControllerDelegate::HasOptionsPage(
@@ -174,11 +170,10 @@ void AppListControllerDelegate::ShowOptionsPage(
if (!extension)
return;
- chrome::NavigateParams params(
- profile,
- extensions::OptionsPageInfo::GetOptionsPage(extension),
- ui::PAGE_TRANSITION_LINK);
- chrome::Navigate(&params);
+ OpenURL(profile,
+ extensions::OptionsPageInfo::GetOptionsPage(extension),
+ ui::PAGE_TRANSITION_LINK,
+ CURRENT_TAB);
}
extensions::LaunchType AppListControllerDelegate::GetExtensionLaunchType(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698