Improve error triggering in sync_integration_tests

Improve error triggering in sync_integration_tests

This CL does the following:
1) Re-enables two test cases in sync_errors_test.cc and converts them
   to use FakeServer. ErrorWhileSettingUp and
   BirthdayErrorUsingActionableErrorTest. Note that ErrorWhileSettingUp
   still fails on Chrome OS, so a separate (disabled) case has been
   created.
2) Adds a feature to FakeServer where triggered errors are sent back to
   the client on every other request (as opposed to every request).
3) FakeServer::TriggerError() now returns a bool to indicate success.
4) Removes dead code (unused as a result of the conversion to
   FakeServer) from SyncTest.

BUG=400806, 406545
Committed: https://crrev.com/a91125d77bf01e9982fce536c95c5f213cf2413e
Cr-Commit-Position: refs/heads/master@{#299765}

[pval...(no longer on Chromium), 2014-10-10 21:27:30]

Patchset #1 (id:1) has been deleted

[pval...(no longer on Chromium), 2014-10-10 21:31:13]

pvalenzuela@chromium.org changed reviewers:
+ zea@chromium.org

[Nicolas Zea, 2014-10-10 23:51:10]

lgtm

https://codereview.chromium.org/650463003/diff/60001/chrome/browser/sync/test...
File chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc
(right):

https://codereview.chromium.org/650463003/diff/60001/chrome/browser/sync/test...
chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc:236:
EXPECT_TRUE(GetFakeServer()->TriggerError(sync_pb::SyncEnums::USER_ROLLBACK));
nit: should these all be ASSERT_TRUE? If this fails, does it make sense to
continue the test?

https://codereview.chromium.org/650463003/diff/60001/sync/test/fake_server/fa...
File sync/test/fake_server/fake_server.h (right):

https://codereview.chromium.org/650463003/diff/60001/sync/test/fake_server/fa...
sync/test/fake_server/fake_server.h:92: // if triggered error alternating was
successful.
Comment why you might want to use this?

[pval...(no longer on Chromium), 2014-10-14 17:26:04]

https://codereview.chromium.org/650463003/diff/60001/chrome/browser/sync/test...
File chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc
(right):

https://codereview.chromium.org/650463003/diff/60001/chrome/browser/sync/test...
chrome/browser/sync/test/integration/single_client_backup_rollback_test.cc:236:
EXPECT_TRUE(GetFakeServer()->TriggerError(sync_pb::SyncEnums::USER_ROLLBACK));
On 2014/10/10 23:51:09, Nicolas Zea wrote:
> nit: should these all be ASSERT_TRUE? If this fails, does it make sense to
> continue the test?

You're right. I was thinking we may want to see what happens afterwards, but
this error should immediately stop the test. It doesn't make sense to continue.

https://codereview.chromium.org/650463003/diff/60001/sync/test/fake_server/fa...
File sync/test/fake_server/fake_server.h (right):

https://codereview.chromium.org/650463003/diff/60001/sync/test/fake_server/fa...
sync/test/fake_server/fake_server.h:92: // if triggered error alternating was
successful.
On 2014/10/10 23:51:09, Nicolas Zea wrote:
> Comment why you might want to use this?

Done.

[pval...(no longer on Chromium), 2014-10-14 17:26:11]

The CQ bit was checked by pvalenzuela@chromium.org

[commit-bot: I haz the power, 2014-10-14 17:26:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650463003/170001

[commit-bot: I haz the power, 2014-10-14 17:31:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 17:31:41]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/68439)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/73174)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pval...(no longer on Chromium), 2014-10-15 00:06:57]

The CQ bit was checked by pvalenzuela@chromium.org

[commit-bot: I haz the power, 2014-10-15 00:08:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650463003/190001

[commit-bot: I haz the power, 2014-10-15 00:46:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-15 00:46:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pval...(no longer on Chromium), 2014-10-15 00:49:40]

The CQ bit was checked by pvalenzuela@chromium.org

[commit-bot: I haz the power, 2014-10-15 00:51:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650463003/190001

[commit-bot: I haz the power, 2014-10-15 01:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-15 01:42:22]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pval...(no longer on Chromium), 2014-10-15 20:20:35]

FYI: Found that a test is still failing on Chrome OS. I've separated it out into
its own test case (as it should be) that is disabled.

[pval...(no longer on Chromium), 2014-10-15 20:20:40]

The CQ bit was checked by pvalenzuela@chromium.org

[commit-bot: I haz the power, 2014-10-15 20:21:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/650463003/210001

[commit-bot: I haz the power, 2014-10-15 21:16:37]

Committed patchset #4 (id:210001)

[commit-bot: I haz the power, 2014-10-15 21:17:31]

Patchset 4 (id:??) landed as
https://crrev.com/a91125d77bf01e9982fce536c95c5f213cf2413e
Cr-Commit-Position: refs/heads/master@{#299765}