Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/sync/test/integration/sync_test.h

Issue 650463003: Improve error triggering in sync_integration_tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sync_test.h
diff --git a/chrome/browser/sync/test/integration/sync_test.h b/chrome/browser/sync/test/integration/sync_test.h
index 912a0cd08315f9b4e9b6871075d48834db3f2c6a..db0e63418510c141d7490a90edaa3010525241a4 100644
--- a/chrome/browser/sync/test/integration/sync_test.h
+++ b/chrome/browser/sync/test/integration/sync_test.h
@@ -94,21 +94,6 @@ class SyncTest : public InProcessBrowserTest {
// LOCAL_PYTHON_SERVER.
};
- // NOTE: IMPORTANT the enum here should match with
- // the enum defined on the chromiumsync.py test server impl.
- enum SyncErrorFrequency {
- // Uninitialized state.
- ERROR_FREQUENCY_NONE,
-
- // Server sends the error on all requests.
- ERROR_FREQUENCY_ALWAYS,
-
- // Server sends the error on two thirds of the request.
- // Note this is not random. The server would send the
- // error on the first 2 requests of every 3 requests.
- ERROR_FREQUENCY_TWO_THIRDS
- };
-
// A SyncTest must be associated with a particular test type.
explicit SyncTest(TestType test_type);
@@ -225,12 +210,6 @@ class SyncTest : public InProcessBrowserTest {
// stay in this state until shut down.
void TriggerXmppAuthError();
- // Triggers a sync error on the server.
- // error: The error the server is expected to return.
- // frequency: Frequency with which the error is returned.
- void TriggerSyncError(const syncer::SyncProtocolError& error,
- SyncErrorFrequency frequency);
-
// Triggers the creation the Synced Bookmarks folder on the server.
void TriggerCreateSyncedBookmarks();
« no previous file with comments | « chrome/browser/sync/test/integration/sync_errors_test.cc ('k') | chrome/browser/sync/test/integration/sync_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698