Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 65043018: Revert 235647 "Add UMA for <webview> APIs: a. ClearData, b. when..." (Closed)

Created:
7 years, 1 month ago by kinuko
Modified:
7 years, 1 month ago
Reviewers:
lazyboy
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 235647 "Add UMA for <webview> APIs: a. ClearData, b. when..." Suspected to break Linux ASAN tests: http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Tests%20%283%29&number=18746 http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Tests%20%282%29&number=19801 > Add UMA for <webview> APIs: a. ClearData, b. when Permission request is allowed. > > BUG=317084 > Test=None > > Review URL: https://codereview.chromium.org/69913002 TBR=lazyboy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -120 lines) Patch
M trunk/src/chrome/browser/guestview/webview/plugin_permission_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/guestview/webview/webview_guest.h View 2 chunks +9 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/guestview/webview/webview_guest.cc View 8 chunks +5 lines, -105 lines 0 comments Download
M trunk/src/content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kinuko
7 years, 1 month ago (2013-11-18 08:35:39 UTC) #1
kinuko
7 years, 1 month ago (2013-11-18 08:35:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r235668.

Powered by Google App Engine
This is Rietveld 408576698