Add UMA for <webview> APIs: a. ClearData, b. when Permission request is allowed.

Add UMA for <webview> APIs: a. ClearData, b. when Permission request is allowed.

BUG=317084
Test=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235647

[Fady Samuel, 2013-11-12 15:20:18]

Can we do this on a per-permission type granularity please?

[lazyboy, 2013-11-12 18:16:59]

Made the uma per permission type.

https://chromiumcodereview.appspot.com/69913002/diff/80001/chrome/browser/gue...
File chrome/browser/guestview/webview/plugin_permission_helper.cc (right):

https://chromiumcodereview.appspot.com/69913002/diff/80001/chrome/browser/gue...
chrome/browser/guestview/webview/plugin_permission_helper.cc:113: // Should we
restrict this only for |user_initiated| = true?
FYI: Pending question. For other permissions, I'm trying to only record
explicitly user initiated allow/deny, to give us a sense if/how the API is being
used.

[Fady Samuel, 2013-11-13 15:54:04]

https://codereview.chromium.org/69913002/diff/80001/content/browser/browser_p...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/69913002/diff/80001/content/browser/browser_p...
content/browser/browser_plugin/browser_plugin_guest.cc:104:
"BrowserPlugin.Guest.PermissionAllow.Download"));
All these strings are really similar. Can't you simply use something like this?
StringPrintf("BrowserPlugin.Guest.PermissionAllow.%s",
PermissionTypeToString(permission))?

[lazyboy, 2013-11-13 17:35:33]

https://codereview.chromium.org/69913002/diff/80001/content/browser/browser_p...
File content/browser/browser_plugin/browser_plugin_guest.cc (right):

https://codereview.chromium.org/69913002/diff/80001/content/browser/browser_p...
content/browser/browser_plugin/browser_plugin_guest.cc:104:
"BrowserPlugin.Guest.PermissionAllow.Download"));
On 2013/11/13 15:54:05, Fady Samuel wrote:
> All these strings are really similar. Can't you simply use something like
this?
> StringPrintf("BrowserPlugin.Guest.PermissionAllow.%s",
> PermissionTypeToString(permission))?

As discussed offline and after talking to sadrul@, these need to be literals.

[Fady Samuel, 2013-11-13 19:29:52]

https://chromiumcodereview.appspot.com/69913002/diff/80001/chrome/browser/gue...
File chrome/browser/guestview/webview/plugin_permission_helper.cc (right):

https://chromiumcodereview.appspot.com/69913002/diff/80001/chrome/browser/gue...
chrome/browser/guestview/webview/plugin_permission_helper.cc:113: // Should we
restrict this only for |user_initiated| = true?
On 2013/11/12 18:16:59, lazyboy wrote:
> FYI: Pending question. For other permissions, I'm trying to only record
> explicitly user initiated allow/deny, to give us a sense if/how the API is
being
> used.

It's useful to record when plugin requests happen but it's also useful to know
when the user makes an explicit request (Are they actually using the
permissionrequest API?).

[lazyboy, 2013-11-13 19:52:50]

https://chromiumcodereview.appspot.com/69913002/diff/80001/chrome/browser/gue...
File chrome/browser/guestview/webview/plugin_permission_helper.cc (right):

https://chromiumcodereview.appspot.com/69913002/diff/80001/chrome/browser/gue...
chrome/browser/guestview/webview/plugin_permission_helper.cc:113: // Should we
restrict this only for |user_initiated| = true?
On 2013/11/13 19:29:52, Fady Samuel wrote:
> On 2013/11/12 18:16:59, lazyboy wrote:
> > FYI: Pending question. For other permissions, I'm trying to only record
> > explicitly user initiated allow/deny, to give us a sense if/how the API is
> being
> > used.
> 
> It's useful to record when plugin requests happen but it's also useful to know
> when the user makes an explicit request (Are they actually using the
> permissionrequest API?).

In that case we can record two separate pairs, a pair when user_initiated=true,
and another when user_initiated=false.
WDYT?

re Are they actually using the permissionrequest API?
only in chrome/ layer(WebViewGuest), it's not initiated or handled in content/
layer (BrowserPluginGuest), so there's no *Request class for plugin request like
other ones do (e.g. class BrowserPluginGuest::NewWindowRequest : public
PermissionRequest).

[lazyboy, 2013-11-14 20:18:15]

Moved UMA recording to webview_guest.cc as discussed offline.

[lazyboy, 2013-11-14 21:01:53]

Shorted string literals.

[Fady Samuel, 2013-11-14 21:05:26]

lgtm

[sadrul, 2013-11-14 21:49:05]

Did you mean to run tools/metrics/actions/extract_actions?

[lazyboy, 2013-11-14 21:50:47]

On 2013/11/14 21:49:05, sadrul wrote:
> Did you mean to run tools/metrics/actions/extract_actions?

We decided to run this separately after this patch, we are already missing some
existing actions for webview, will do that in one go.

[commit-bot: I haz the power, 2013-11-14 23:48:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/69913002/230001

[commit-bot: I haz the power, 2013-11-15 02:11:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/69913002/230001

[commit-bot: I haz the power, 2013-11-15 04:12:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/69913002/230001

[commit-bot: I haz the power, 2013-11-15 07:08:36]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-15 09:38:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/69913002/230001

[commit-bot: I haz the power, 2013-11-15 11:52:39]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-15 16:55:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/69913002/230001

[commit-bot: I haz the power, 2013-11-15 22:18:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/69913002/230001

[commit-bot: I haz the power, 2013-11-16 00:51:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lazyboy@chromium.org/69913002/230001

[commit-bot: I haz the power, 2013-11-18 07:48:24]

Change committed as 235647

[Alexander Potapenko, 2013-11-18 08:43:29]

On 2013/11/18 07:48:24, I haz the power (commit-bot) wrote:
> Change committed as 235647

kinuko@ reverted this CL because it broke browser_tests under ASan on Linux.
There are linux_asan and linux_browser_asan trybots to aid you,
http://dev.chromium.org/developers/testing/addresssanitizer contains the
instructions on running ASan locally.