Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: mojo/public/bindings/lib/message.h

Issue 65043004: Add better handle tracking, and optimize Connector::Accept. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update per review feedback Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/bindings/lib/connector.cc ('k') | mojo/public/bindings/lib/message.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/bindings/lib/message.h
diff --git a/mojo/public/bindings/lib/message.h b/mojo/public/bindings/lib/message.h
index 742f12195e7570dc55bf8c7ce2566602ae25e8b9..bb9de251c242f921bedb9c671499b365fc304381 100644
--- a/mojo/public/bindings/lib/message.h
+++ b/mojo/public/bindings/lib/message.h
@@ -28,9 +28,8 @@ MOJO_COMPILE_ASSERT(sizeof(MessageData) == 9, bad_sizeof_MessageData);
#pragma pack(pop)
// Message is a holder for the data and handles to be sent over a MessagePipe.
-// Message owns its data, but a consumer of Message is free to manipulate the
-// data member or replace it. If replacing, then be sure to use |malloc| to
-// allocate the memory.
+// Message owns its data and handles, but a consumer of Message is free to
+// manipulate the data and handles members.
class Message {
public:
Message();
@@ -38,7 +37,7 @@ class Message {
void Swap(Message* other);
- MessageData* data; // Heap-allocated.
+ MessageData* data; // Heap-allocated using malloc.
std::vector<Handle> handles;
private:
« no previous file with comments | « mojo/public/bindings/lib/connector.cc ('k') | mojo/public/bindings/lib/message.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698