ppapi/proxy/dispatch_reply_message.h - Issue 650393002: Modify ALLOW_UNUSED to allow enabling unused local warnings on MSVC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/dispatch_reply_message.h

Issue 650393002: Modify ALLOW_UNUSED to allow enabling unused local warnings on MSVC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert review comment Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/dispatch_reply_message.h

diff --git a/ppapi/proxy/dispatch_reply_message.h b/ppapi/proxy/dispatch_reply_message.h

index 56a450891b71093831dac19d2b3b21ce5cf7553f..bb4b7d7d9310e10c60bb36a9d6eae45dc26ed772 100644

--- a/ppapi/proxy/dispatch_reply_message.h

+++ b/ppapi/proxy/dispatch_reply_message.h

@@ -134,7 +134,7 @@ void DispatchResourceReplyOrDefaultParams(

// unused variables or other errors if they're used with these macros.

#define PPAPI_BEGIN_MESSAGE_MAP(class_name, msg) \

{ \

- typedef class_name _IpcMessageHandlerClass ALLOW_UNUSED; \

+ typedef class_name _IpcMessageHandlerClass ALLOW_UNUSED_TYPE; \

const IPC::Message& ipc_message__ = msg; \

switch (ipc_message__.type()) { \

« base/compiler_specific.h ('K') | « ipc/ipc_message_macros.h ('k') | ui/gl/generate_bindings.py » ('j') | no next file with comments »