ui/gl/generate_bindings.py - Issue 650393002: Modify ALLOW_UNUSED to allow enabling unused local warnings on MSVC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/generate_bindings.py

Issue 650393002: Modify ALLOW_UNUSED to allow enabling unused local warnings on MSVC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert review comment Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gl/generate_bindings.py

diff --git a/ui/gl/generate_bindings.py b/ui/gl/generate_bindings.py

index 303c01ebb5567229893b8e16bdb8323e190a2bd3..b135cac46dead16b4e2170e272356daebc25ddd6 100755

--- a/ui/gl/generate_bindings.py

+++ b/ui/gl/generate_bindings.py

@@ -1521,9 +1521,10 @@ namespace gfx {

# on the extension string or the GL version.

file.write("""void Driver%s::InitializeDynamicBindings(GLContext* context) {

DCHECK(context && context->IsCurrent(NULL));

- const GLVersionInfo* ver ALLOW_UNUSED = context->GetVersionInfo();

- std::string extensions ALLOW_UNUSED = context->GetExtensions();

- extensions += " ";

+ const GLVersionInfo* ver = context->GetVersionInfo();

+ ALLOW_UNUSED_LOCAL(ver);

+ std::string extensions = context->GetExtensions() + " ";

+ ALLOW_UNUSED_LOCAL(extensions);

""" % set_name.upper())

for extension in sorted(used_extensions):

« base/compiler_specific.h ('K') | « ppapi/proxy/dispatch_reply_message.h ('k') | no next file » | no next file with comments »