Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 650303003: Avoid type truncation warnings when converting GLenum to GLboolean by inserting (Closed)

Created:
6 years, 2 months ago by Peter Kasting
Modified:
6 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Avoid type truncation warnings when converting GLenum to GLboolean by inserting an explicit "!= 0". BUG=81439 TEST=none Committed: https://crrev.com/c52fefe6fbd9450e7a8d064fd02e2afbfdfe1700 Cr-Commit-Position: refs/heads/master@{#299400}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Peter Kasting
6 years, 2 months ago (2014-10-13 22:50:50 UTC) #2
Zhenyao Mo
On 2014/10/13 22:50:50, Peter Kasting wrote: LGTM
6 years, 2 months ago (2014-10-13 23:11:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650303003/1
6 years, 2 months ago (2014-10-13 23:26:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/67941)
6 years, 2 months ago (2014-10-13 23:37:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650303003/1
6 years, 2 months ago (2014-10-13 23:44:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 00:15:27 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 00:16:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c52fefe6fbd9450e7a8d064fd02e2afbfdfe1700
Cr-Commit-Position: refs/heads/master@{#299400}

Powered by Google App Engine
This is Rietveld 408576698