Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 650293002: Add test for requestAutocomplete and readonly attribute. (Closed)

Created:
6 years, 2 months ago by Evan Stade
Modified:
6 years, 2 months ago
Reviewers:
Mike West, Ilya Sherman
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, ziran.sun
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add test for requestAutocomplete and readonly attribute. BUG=231160 Committed: https://crrev.com/8e4b94a505d46a79f50183c276bb144e2fe156fe Cr-Commit-Position: refs/heads/master@{#299411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Evan Stade
6 years, 2 months ago (2014-10-13 18:59:22 UTC) #2
Ilya Sherman
LGTM I see, so it's not that we're overwriting readonly fields; it's that we need ...
6 years, 2 months ago (2014-10-13 21:13:05 UTC) #3
Evan Stade
On 2014/10/13 21:13:05, Ilya Sherman wrote: > LGTM > > I see, so it's not ...
6 years, 2 months ago (2014-10-13 21:17:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/650293002/1
6 years, 2 months ago (2014-10-14 00:32:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 01:12:13 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 01:12:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e4b94a505d46a79f50183c276bb144e2fe156fe
Cr-Commit-Position: refs/heads/master@{#299411}

Powered by Google App Engine
This is Rietveld 408576698